Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/234430
Change subject: Fix subscriber count in TablePager
......................................................................
Fix subscriber count in TablePager
Change-Id: I4e967439a4f13ba9981422c0ecdc0424b2c12d48
---
M includes/NewsletterTablePager.php
1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/30/234430/1
diff --git a/includes/NewsletterTablePager.php
b/includes/NewsletterTablePager.php
index f8abb68..e599027 100644
--- a/includes/NewsletterTablePager.php
+++ b/includes/NewsletterTablePager.php
@@ -25,16 +25,14 @@
public function getQueryInfo() {
$info = array(
- 'tables' => array( 'nl_newsletters', 'nl_subscriptions'
),
+ 'tables' => array( 'nl_newsletters' ),
'fields' => array(
'nl_name',
'nl_desc',
'nl_id',
- 'subscribers' => (
'COUNT(nl_subscriptions.newsletter_id)' ),
+ 'subscribers' => ( '( SELECT COUNT(*) FROM
nl_subscriptions WHERE newsletter_id = nl_id )' ),
),
- 'join_conds' => array(
- 'nl_subscriptions' => array( 'LEFT JOIN',
'newsletter_id = nl_id' ),
- ),
+ 'options' => array( 'DISTINCT nl_id' ),
);
return $info;
--
To view, visit https://gerrit.wikimedia.org/r/234430
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e967439a4f13ba9981422c0ecdc0424b2c12d48
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
