Giuseppe Lavagetto has submitted this change and it was merged. Change subject: gridengine: Fix status check for gridengine-exec ......................................................................
gridengine: Fix status check for gridengine-exec Even though I am *very* certain that I tested both on toolsbeta-exec-101 and toolsbeta-exec-202 *exactly* that indeed the gridengine-exec service was identified as running when there was an sge_execd process, somewhere down the line reality shifted and now Puppet is behaving as documented at https://docs.puppetlabs.com/references/latest/type.html#service-attribute-hasstatus: | [...] | If a service's init script does not support any kind of status | command, you should set hasstatus to false and either provide a | specific command using the status attribute or expect that Puppet will | look for the service name in the process table. [...] So this change sets hasstatus to false to force Puppet to use the pattern attribute. Bug: T110532 Change-Id: I1244c55c77e605d3e98d0436ee7923a156223a93 --- M modules/gridengine/manifests/exec_host.pp 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Merlijn van Deen: Looks good to me, but someone else must approve Giuseppe Lavagetto: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/gridengine/manifests/exec_host.pp b/modules/gridengine/manifests/exec_host.pp index b546f52..da85129 100644 --- a/modules/gridengine/manifests/exec_host.pp +++ b/modules/gridengine/manifests/exec_host.pp @@ -12,10 +12,11 @@ } service { 'gridengine-exec': - ensure => running, - enable => true, - pattern => 'sge_execd', - require => Package['gridengine-exec'], + ensure => running, + enable => true, + hasstatus => false, + pattern => 'sge_execd', + require => Package['gridengine-exec'], } gridengine::resource { "exec-${::fqdn}": -- To view, visit https://gerrit.wikimedia.org/r/234432 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1244c55c77e605d3e98d0436ee7923a156223a93 Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Tim Landscheidt <[email protected]> Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]> Gerrit-Reviewer: Merlijn van Deen <[email protected]> Gerrit-Reviewer: Tim Landscheidt <[email protected]> Gerrit-Reviewer: Yuvipanda <[email protected]> Gerrit-Reviewer: coren <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
