jenkins-bot has submitted this change and it was merged.
Change subject: Simplify hasOwnProperty checks in wikibase.getLanguageNameByCode
......................................................................
Simplify hasOwnProperty checks in wikibase.getLanguageNameByCode
I do not think the shortcut is worth it, when only used 2 times.
Change-Id: I1f7a74a369ea3753f2e4538e068376e416b82166
---
M view/resources/wikibase/wikibase.getLanguageNameByCode.js
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/view/resources/wikibase/wikibase.getLanguageNameByCode.js
b/view/resources/wikibase/wikibase.getLanguageNameByCode.js
index ee3ba65..bb50840 100644
--- a/view/resources/wikibase/wikibase.getLanguageNameByCode.js
+++ b/view/resources/wikibase/wikibase.getLanguageNameByCode.js
@@ -8,8 +8,6 @@
( function ( wb, mw, $ ) {
'use strict';
- var hasOwn = Object.prototype.hasOwnProperty;
-
/**
* Tries to retrieve Universal Language Selector's set of languages.
*
@@ -33,7 +31,8 @@
*/
var getNativeLanguageName = function( langCode ) {
var languages = getLanguages();
- return hasOwn.call( languages, langCode ) &&
languages[langCode][2] || langCode;
+ return Object.prototype.hasOwnProperty.call( languages,
langCode ) && languages[langCode][2]
+ || langCode;
};
/**
@@ -45,8 +44,8 @@
*/
wb.getLanguageNameByCode = function( langCode ) {
var ulsLanguages = mw.config.get( 'wgULSLanguages' );
- return ulsLanguages && hasOwn.call( ulsLanguages, langCode ) &&
ulsLanguages[langCode]
- || getNativeLanguageName( langCode );
+ return ulsLanguages && Object.prototype.hasOwnProperty.call(
ulsLanguages, langCode )
+ && ulsLanguages[ langCode ] || getNativeLanguageName(
langCode );
};
} )( wikibase, mediaWiki, jQuery );
--
To view, visit https://gerrit.wikimedia.org/r/232481
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f7a74a369ea3753f2e4538e068376e416b82166
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Fomafix
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
