Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/234491

Change subject: Remove wikibase.special module from modules that don't need it
......................................................................

Remove wikibase.special module from modules that don't need it

* SpecialRedirectEntity used it but does not any more after it switched
to the OOJS CSS. Missed that in I1eb2deb.
* The suggester module never used it, as far as I can tell. This was an
oversight when reviewing I51da1f4.

Change-Id: I6876328f3fefcad45039d21a8d2cb7f634180afc
---
M repo/Wikibase.hooks.php
M repo/includes/specials/SpecialRedirectEntity.php
2 files changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/91/234491/1

diff --git a/repo/Wikibase.hooks.php b/repo/Wikibase.hooks.php
index 46e7377..778fb5d 100644
--- a/repo/Wikibase.hooks.php
+++ b/repo/Wikibase.hooks.php
@@ -1159,7 +1159,6 @@
                                        
'resources/wikibase.special/wikibase.special.languageSuggester.js',
                                ),
                                'dependencies' => array(
-                                       'wikibase.special',
                                        'jquery.ui.suggester',
                                ),
                        ),
diff --git a/repo/includes/specials/SpecialRedirectEntity.php 
b/repo/includes/specials/SpecialRedirectEntity.php
index cc28730..f7a91f0 100644
--- a/repo/includes/specials/SpecialRedirectEntity.php
+++ b/repo/includes/specials/SpecialRedirectEntity.php
@@ -165,8 +165,6 @@
         * Creates the HTML form for redirecting an entity
         */
        protected function createForm() {
-               $this->getOutput()->addModuleStyles( array( 'wikibase.special' 
) );
-
                $pre = '';
                if ( $this->getUser()->isAnon() ) {
                        $pre = Html::rawElement(

-- 
To view, visit https://gerrit.wikimedia.org/r/234491
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6876328f3fefcad45039d21a8d2cb7f634180afc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to