Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/234498
Change subject: Fixed Style/DefWithParentheses RuboCop offense
......................................................................
Fixed Style/DefWithParentheses RuboCop offense
Bug: T106220
Change-Id: I95705910fd8470f60dbeb0a618fc7cf7957fb1ea
---
M .rubocop_todo.yml
M support/packager/package.rb
2 files changed, 5 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant
refs/changes/98/234498/1
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 0f4a7a6..acfb7e1 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -22,11 +22,6 @@
Style/CaseEquality:
Enabled: false
-# Offense count: 5
-# Cop supports --auto-correct.
-Style/DefWithParentheses:
- Enabled: false
-
# Offense count: 4
Style/DoubleNegation:
Enabled: false
diff --git a/support/packager/package.rb b/support/packager/package.rb
index ecdd3af..bd99287 100755
--- a/support/packager/package.rb
+++ b/support/packager/package.rb
@@ -81,7 +81,7 @@
end
end
-def common()
+def common
old_cwd = Dir.pwd
mkdir_p($contents_dir)
@@ -119,7 +119,7 @@
cp(template + 'LICENSE', $contents_dir)
end
-def linux()
+def linux
linux_dir = $contents_dir + 'Linux'
$url_config['VirtualBox']['Linux'].each do |distro, url|
@@ -133,21 +133,21 @@
end
end
-def mac()
+def mac
mac_dir = $contents_dir + 'Mac'
download_file(mac_dir, $url_config['VirtualBox']['Mac'])
download_file(mac_dir, $url_config['Vagrant']['Mac'])
download_file(mac_dir, $url_config['Git']['Mac'])
end
-def windows()
+def windows
windows_dir = $contents_dir + 'Windows'
download_file(windows_dir, $url_config['VirtualBox']['Windows'])
download_file(windows_dir, $url_config['Vagrant']['Windows'])
download_file(windows_dir, $url_config['Git']['Windows'])
end
-def build_iso()
+def build_iso
puts 'Creating iso image to distribute...'
# -r: Rock Ridge with recommended values for permissions, etc.
if system('which genisoimage >/dev/null 2>&1')
--
To view, visit https://gerrit.wikimedia.org/r/234498
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95705910fd8470f60dbeb0a618fc7cf7957fb1ea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
