Dzahn has submitted this change and it was merged.

Change subject: mailman: no gate_news debconf option on >= jessie
......................................................................


mailman: no gate_news debconf option on >= jessie

"gate_news" is mailman's newsgroup to mail gateway.

This option does not exist anymore in the jessie version of the
package.

@fermium:~# echo get mailman/gate_news | debconf-communicate
10 mailman/gate_news doesn't exist

@sodium:~# echo get mailman/gate_news | debconf-communicate
0 false

It causes puppet errors if we still try to set it on jessie:

Mailman::Listserve/Exec[dpkg-reconfigure mailman]:
Dependency Exec[debconf-communicate set mailman/gate_news] has failures: true

Bug:T109925
Change-Id: Ib01baf00aca8c978e34b9553e29d1ef1bffee702
---
M modules/mailman/manifests/listserve.pp
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  JanZerebecki: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/mailman/manifests/listserve.pp 
b/modules/mailman/manifests/listserve.pp
index e1cd3c5..4626f6b 100644
--- a/modules/mailman/manifests/listserve.pp
+++ b/modules/mailman/manifests/listserve.pp
@@ -13,9 +13,12 @@
     # Install as many languages as possible
     include locales::extended
 
-    debconf::set { 'mailman/gate_news':
-        value  => 'false',
-        notify => Exec['dpkg-reconfigure mailman'],
+    if os_version ( 'debian <= jessie || ubuntu <= precise') {
+
+        debconf::set { 'mailman/gate_news':
+            value  => 'false',
+            notify => Exec['dpkg-reconfigure mailman'],
+        }
     }
 
     debconf::set { 'mailman/site_languages':

-- 
To view, visit https://gerrit.wikimedia.org/r/234462
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib01baf00aca8c978e34b9553e29d1ef1bffee702
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: JanZerebecki <jan.wikime...@zerebecki.de>
Gerrit-Reviewer: John F. Lewis <johnflewi...@gmail.com>
Gerrit-Reviewer: Mark Bergsma <m...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to