jenkins-bot has submitted this change and it was merged.
Change subject: Fix focusable mouseout
......................................................................
Fix focusable mouseout
We should detect mouseout of this.$focusable, not this.$element.
Bug: T110195
Change-Id: Ifd071eaccdf543a707ef839d5ea0f715e9d2be8c
---
M src/ce/ve.ce.FocusableNode.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ce/ve.ce.FocusableNode.js b/src/ce/ve.ce.FocusableNode.js
index b4ceaa7..2693d57 100644
--- a/src/ce/ve.ce.FocusableNode.js
+++ b/src/ce/ve.ce.FocusableNode.js
@@ -285,7 +285,7 @@
var $target = $( e.target );
if (
!$target.hasClass( 've-ce-focusableNode-highlight' ) &&
- $target.closest( '.ve-ce-focusableNode' ).length === 0
+ !OO.ui.contains( this.$focusable.toArray(), $target[ 0 ], true )
) {
this.clearHighlights();
}
--
To view, visit https://gerrit.wikimedia.org/r/232773
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd071eaccdf543a707ef839d5ea0f715e9d2be8c
Gerrit-PatchSet: 3
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
