John Vandenberg has uploaded a new change for review.
https://gerrit.wikimedia.org/r/234840
Change subject: Use a different Q for test_item_missing
......................................................................
Use a different Q for test_item_missing
Q404 was restored, causing test_item_missing to fail.
Make it variable.
Bug: T110819
Change-Id: I96909daec59160e03d2217c5e7ba97aa1d69ee4a
---
M tests/wikibase_tests.py
1 file changed, 16 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/40/234840/1
diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py
index 28be15f..c183e1a 100644
--- a/tests/wikibase_tests.py
+++ b/tests/wikibase_tests.py
@@ -321,26 +321,29 @@
def test_item_missing(self):
wikidata = self.get_repo()
+ Q404 = 'Q12197221'
# this item is deleted
- item = pywikibot.ItemPage(wikidata, 'Q404')
- self.assertEqual(item._link._title, 'Q404')
- self.assertEqual(item.title(), 'Q404')
+ item = pywikibot.ItemPage(wikidata, Q404)
+ self.assertEqual(item._link._title, Q404)
+ self.assertEqual(item.title(), Q404)
self.assertFalse(hasattr(item, '_content'))
- self.assertEqual(item.id, 'Q404')
- self.assertEqual(item.getID(), 'Q404')
- self.assertEqual(item.getID(numeric=True), 404)
+ self.assertEqual(item.id, Q404)
+ self.assertEqual(item.getID(), Q404)
+ numeric_id = item.getID(numeric=True)
+ self.assertIsInstance(numeric_id, int)
+ self.assertEqual(numeric_id, int(Q404[1:]))
self.assertFalse(hasattr(item, '_content'))
self.assertRaises(pywikibot.NoPage, item.get)
self.assertTrue(hasattr(item, '_content'))
- self.assertEqual(item.id, 'Q404')
- self.assertEqual(item.getID(), 'Q404')
- self.assertEqual(item._link._title, 'Q404')
- self.assertEqual(item.title(), 'Q404')
+ self.assertEqual(item.id, Q404)
+ self.assertEqual(item.getID(), Q404)
+ self.assertEqual(item._link._title, Q404)
+ self.assertEqual(item.title(), Q404)
self.assertRaises(pywikibot.NoPage, item.get)
self.assertTrue(hasattr(item, '_content'))
- self.assertEqual(item._link._title, 'Q404')
- self.assertEqual(item.getID(), 'Q404')
- self.assertEqual(item.title(), 'Q404')
+ self.assertEqual(item._link._title, Q404)
+ self.assertEqual(item.getID(), Q404)
+ self.assertEqual(item.title(), Q404)
def test_item_never_existed(self):
wikidata = self.get_repo()
--
To view, visit https://gerrit.wikimedia.org/r/234840
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96909daec59160e03d2217c5e7ba97aa1d69ee4a
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
