Subramanya Sastry has uploaded a new change for review.
https://gerrit.wikimedia.org/r/234853
Change subject: Use Util.decodeURI instead of decodeURI: followup on 3c5334fcb
......................................................................
Use Util.decodeURI instead of decodeURI: followup on 3c5334fcb
* Prevents unencoded urls from crashing the serializer
Change-Id: Ic847c06299d49b09d1be19af03b4ff18135662c8
---
M lib/wts.LinkHandler.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/53/234853/1
diff --git a/lib/wts.LinkHandler.js b/lib/wts.LinkHandler.js
index 92e1afd..598cb5e 100644
--- a/lib/wts.LinkHandler.js
+++ b/lib/wts.LinkHandler.js
@@ -591,7 +591,7 @@
return;
} else {
// TODO: match vs. interwikis too
- var magicLinkMatch =
wiki.ExtResourceURLPatternMatcher.match(decodeURI(linkData.origHref));
+ var magicLinkMatch =
wiki.ExtResourceURLPatternMatcher.match(Util.decodeURI(linkData.origHref));
// Fully serialize the content
contentStr = state.serializeLinkChildrenToString(node,
state.serializer.wteHandlers.aHandler);
@@ -634,7 +634,7 @@
// Get the rt data from the token and tplAttrs
var linkData = getLinkRoundTripData(env, node, state);
var linkType = linkData.type;
- if
(wiki.ExtResourceURLPatternMatcher.match(decodeURI(linkData.origHref))) {
+ if
(wiki.ExtResourceURLPatternMatcher.match(Util.decodeURI(linkData.origHref))) {
// Override the 'rel' type if this is a magic link
linkType = 'mw:ExtLink';
}
--
To view, visit https://gerrit.wikimedia.org/r/234853
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic847c06299d49b09d1be19af03b4ff18135662c8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <ssas...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
