jenkins-bot has submitted this change and it was merged.
Change subject: Fix misleading/incomplete array type hints in repo classes
......................................................................
Fix misleading/incomplete array type hints in repo classes
Change-Id: I17ead686c111401e173bb77446351bb4b06cf244
---
M repo/includes/api/EditEntity.php
M repo/includes/api/ItemByTitleHelper.php
2 files changed, 8 insertions(+), 9 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/api/EditEntity.php b/repo/includes/api/EditEntity.php
index ca3c2a8..883b830 100644
--- a/repo/includes/api/EditEntity.php
+++ b/repo/includes/api/EditEntity.php
@@ -308,16 +308,14 @@
}
if ( array_key_exists( 'claims', $data ) ) {
- $changeOps->add(
- $this->getClaimsChangeOps( $data['claims'] )
- );
+ $changeOps->add( $this->getClaimsChangeOps(
$data['claims'] ) );
}
return $changeOps;
}
/**
- * @param array[] $labels
+ * @param mixed $labels
*
* @return ChangeOp[]
*/
@@ -346,7 +344,7 @@
}
/**
- * @param array[] $descriptions
+ * @param mixed $descriptions
*
* @return ChangeOp[]
*/
@@ -375,7 +373,7 @@
}
/**
- * @param array[] $aliases
+ * @param mixed $aliases
*
* @return ChangeOp[]
*/
@@ -444,7 +442,7 @@
}
/**
- * @param array[] $siteLinks
+ * @param mixed $siteLinks
* @param Item $item
*
* @return ChangeOp[]
@@ -504,7 +502,7 @@
}
/**
- * @param array[] $claims
+ * @param mixed $claims
*
* @return ChangeOp[]
*/
@@ -512,6 +510,7 @@
if ( !is_array( $claims ) ) {
$this->errorReporter->dieError( "List of claims must be
an array", 'not-recognized-array' );
}
+
$changeOps = array();
//check if the array is associative or in arrays by property
diff --git a/repo/includes/api/ItemByTitleHelper.php
b/repo/includes/api/ItemByTitleHelper.php
index 7681176..87e503d 100644
--- a/repo/includes/api/ItemByTitleHelper.php
+++ b/repo/includes/api/ItemByTitleHelper.php
@@ -66,7 +66,7 @@
* @param bool $normalize
*
* @throws UsageException
- * @return array( ItemId[], array() )
+ * @return array( ItemId[], array[] )
* List containing valid ItemIds and MissingItem site title
combinations
*/
public function getItemIds( array $sites, array $titles, $normalize ) {
--
To view, visit https://gerrit.wikimedia.org/r/233356
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17ead686c111401e173bb77446351bb4b06cf244
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
