jenkins-bot has submitted this change and it was merged.
Change subject: New Wikidata Build - 2015-08-31T10:00:01+0000
......................................................................
New Wikidata Build - 2015-08-31T10:00:01+0000
Change-Id: Ie0fd6f77dde4e45337cdd3dabcddbd872da12c42
---
M composer.lock
A extensions/Wikibase/client/i18n/arz.json
M extensions/Wikibase/client/i18n/as.json
M extensions/Wikibase/client/i18n/km.json
M extensions/Wikibase/client/i18n/olo.json
M extensions/Wikibase/client/i18n/udm.json
A extensions/Wikibase/lib/i18n/arz.json
M extensions/Wikibase/lib/i18n/km.json
M extensions/Wikibase/lib/includes/store/GenericEntityInfoBuilder.php
M extensions/Wikibase/lib/includes/store/sql/SqlEntityInfoBuilder.php
A extensions/Wikibase/repo/i18n/arz.json
M extensions/Wikibase/repo/i18n/km.json
M extensions/Wikibase/repo/includes/api/EditEntity.php
M extensions/Wikibase/repo/includes/api/ItemByTitleHelper.php
M extensions/Wikibase/repo/includes/specials/SpecialGoToLinkedPage.php
M
extensions/Wikibase/repo/resources/wikibase.special/wikibase.special.itemByTitle.js
M vendor/composer/installed.json
17 files changed, 127 insertions(+), 89 deletions(-)
Approvals:
JanZerebecki: Looks good to me, approved
jenkins-bot: Verified
diff --git a/composer.lock b/composer.lock
index 37dba54..a093d39 100644
--- a/composer.lock
+++ b/composer.lock
@@ -1386,12 +1386,12 @@
"source": {
"type": "git",
"url":
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git";,
- "reference": "ab33b656d538b4bd0faec99d9e82ce0eda28cda5"
+ "reference": "adf606c3fb089e4045614d344a0627ccf08c82e5"
},
"dist": {
"type": "zip",
- "url":
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/ab33b656d538b4bd0faec99d9e82ce0eda28cda5";,
- "reference": "ab33b656d538b4bd0faec99d9e82ce0eda28cda5",
+ "url":
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/adf606c3fb089e4045614d344a0627ccf08c82e5";,
+ "reference": "adf606c3fb089e4045614d344a0627ccf08c82e5",
"shasum": ""
},
"require": {
@@ -1460,7 +1460,7 @@
"wikibaserepo",
"wikidata"
],
- "time": "2015-08-29 19:47:55"
+ "time": "2015-08-31 09:47:38"
},
{
"name": "wikibase/wikimedia-badges",
diff --git a/extensions/Wikibase/client/i18n/arz.json
b/extensions/Wikibase/client/i18n/arz.json
new file mode 100644
index 0000000..99d42a0
--- /dev/null
+++ b/extensions/Wikibase/client/i18n/arz.json
@@ -0,0 +1,15 @@
+{
+ "@metadata": {
+ "authors": [
+ "Ghaly"
+ ]
+ },
+ "wikibase-comment-update": "تغيير عنصر {{WBREPONAME}}",
+ "wikibase-editlinks": "عدل الوصلات",
+ "wikibase-editlinkstitle": "تعديل الروابط ما بين اللغات",
+ "wikibase-rc-hide-wikidata": "$1 {{WBREPONAME}}",
+ "wikibase-rc-hide-wikidata-hide": "تخبية",
+ "wikibase-rc-hide-wikidata-show": "عرض",
+ "wikibase-rc-wikibase-edit-letter": "د",
+ "wikibase-rc-wikibase-edit-title": "تعديل {{WBREPONAME}}"
+}
diff --git a/extensions/Wikibase/client/i18n/as.json
b/extensions/Wikibase/client/i18n/as.json
index 93c9cc4..5d46fbf 100644
--- a/extensions/Wikibase/client/i18n/as.json
+++ b/extensions/Wikibase/client/i18n/as.json
@@ -27,6 +27,7 @@
"wikibase-rc-hide-wikidata-show": "দেখুৱাওক",
"wikibase-rc-wikibase-edit-letter": "ড",
"wikibase-rc-wikibase-edit-title": "{{WBREPONAME}} সম্পাদনা",
+ "wikibase-replicationnote": "অনুগ্ৰহ কৰি লক্ষ্য কৰিব যে এই সালসলনি সকলো
ৱিকিতে দৃশ্যমান হ'বলৈ কেইবামিনিটো লাগিব পাৰে।",
"wikibase-unconnectedpages-submit": "যাওক",
"wikibase-unconnectedpages-invalid-language": "\"$1\" কোনো বৈধ ভাষা ক'ড
নহয়।",
"wikibase-otherprojects": "আন প্ৰকল্পসমূহ"
diff --git a/extensions/Wikibase/client/i18n/km.json
b/extensions/Wikibase/client/i18n/km.json
index 4253082..13bbd58 100644
--- a/extensions/Wikibase/client/i18n/km.json
+++ b/extensions/Wikibase/client/i18n/km.json
@@ -8,11 +8,13 @@
"wikibase-comment-unlink": "ទំព័រនេះត្រូវបានផ្ដាច់តំណពីវត្ថុ
{{WBREPONAME}} ហើយ។ តំណភាសាក៏ត្រូវបានដកចេញដែរ។",
"wikibase-editlinks": "កែប្រែតំណភ្ជាប់",
"wikibase-editlinkstitle": "កែប្រែតំណភ្ជាប់អន្តរភាសា",
+ "wikibase-linkitem-input-site": "ភាសា៖",
"wikibase-rc-hide-wikidata": "$1 {{WBREPONAME}}",
"wikibase-rc-hide-wikidata-hide": "លាក់",
"wikibase-rc-hide-wikidata-show": "បង្ហាញ",
"wikibase-rc-wikibase-edit-letter": "ទិន",
"wikibase-rc-wikibase-edit-title": "កែណែប្រែរបស់{{WBREPONAME}}",
+ "wikibase-unconnectedpages-invalid-language": "\"$1\"
មិនមែនជាកូដភាសាត្រឹមត្រូវទេ។",
"wikibase-otherprojects": "គម្រោងផ្សេងៗទៀត",
"wikibase-otherprojects-beta-message": "គម្រោងដទៃទៀតនៅរបារចំហៀង"
}
diff --git a/extensions/Wikibase/client/i18n/olo.json
b/extensions/Wikibase/client/i18n/olo.json
index 307f5ad..d3d9a2a 100644
--- a/extensions/Wikibase/client/i18n/olo.json
+++ b/extensions/Wikibase/client/i18n/olo.json
@@ -5,6 +5,7 @@
"Ilja.mos"
]
},
+ "wikibase-comment-update": "{{WBREPONAME}} on muutettu",
"wikibase-dataitem": "{{WBREPONAME}} elementu",
"wikibase-editlinks": "Korjata linkit",
"wikibase-editlinkstitle": "Korjata kielienvälizet linkit",
diff --git a/extensions/Wikibase/client/i18n/udm.json
b/extensions/Wikibase/client/i18n/udm.json
index 959cfbd..e636c4d 100644
--- a/extensions/Wikibase/client/i18n/udm.json
+++ b/extensions/Wikibase/client/i18n/udm.json
@@ -6,6 +6,6 @@
]
},
"wikibase-editlinks": "Чӧлсконъёсыз тупатыны",
- "wikibase-rc-wikibase-edit-title": "Тупатон
{{grammar:genitive|{{WBREPONAME}}}}",
+ "wikibase-rc-wikibase-edit-title": "{{grammar:genitive|{{WBREPONAME}}}}
тупатон",
"wikibase-otherprojects": "Мукет проектъёсын"
}
diff --git a/extensions/Wikibase/lib/i18n/arz.json
b/extensions/Wikibase/lib/i18n/arz.json
new file mode 100644
index 0000000..6235cc4
--- /dev/null
+++ b/extensions/Wikibase/lib/i18n/arz.json
@@ -0,0 +1,8 @@
+{
+ "@metadata": {
+ "authors": [
+ "Ghaly"
+ ]
+ },
+ "wikibase-sitelinks-wikipedia": "ويكيبديا"
+}
diff --git a/extensions/Wikibase/lib/i18n/km.json
b/extensions/Wikibase/lib/i18n/km.json
index 0b0ba40..3e560b3 100644
--- a/extensions/Wikibase/lib/i18n/km.json
+++ b/extensions/Wikibase/lib/i18n/km.json
@@ -6,5 +6,6 @@
]
},
"wikibase-sitelinks-wikipedia": "វិគីភីឌា",
+ "wikibase-sitelinks-sitename-columnheading": "ភាសា",
"wikibase-validator-invalid": "តម្លៃមិនត្រឹមត្រូវ"
}
diff --git
a/extensions/Wikibase/lib/includes/store/GenericEntityInfoBuilder.php
b/extensions/Wikibase/lib/includes/store/GenericEntityInfoBuilder.php
index 3185aea..0745b8b 100644
--- a/extensions/Wikibase/lib/includes/store/GenericEntityInfoBuilder.php
+++ b/extensions/Wikibase/lib/includes/store/GenericEntityInfoBuilder.php
@@ -183,7 +183,12 @@
}
}
- private function injectFingerprint( $types, array &$entityRecord,
Fingerprint $fingerprint, $languages ) {
+ private function injectFingerprint(
+ array $types = null,
+ array &$entityRecord,
+ Fingerprint $fingerprint,
+ array $languages = null
+ ) {
if ( $types === null || in_array( 'label', $types ) ) {
$labels = $fingerprint->getLabels();
diff --git
a/extensions/Wikibase/lib/includes/store/sql/SqlEntityInfoBuilder.php
b/extensions/Wikibase/lib/includes/store/sql/SqlEntityInfoBuilder.php
index 27ce3b6..fb8108b 100644
--- a/extensions/Wikibase/lib/includes/store/sql/SqlEntityInfoBuilder.php
+++ b/extensions/Wikibase/lib/includes/store/sql/SqlEntityInfoBuilder.php
@@ -616,7 +616,7 @@
*
* @return array
*/
- private function ungroup( $groupedArrays ) {
+ private function ungroup( array $groupedArrays ) {
$merged = array_reduce(
$groupedArrays,
function ( $acc, $next ) {
diff --git a/extensions/Wikibase/repo/i18n/arz.json
b/extensions/Wikibase/repo/i18n/arz.json
new file mode 100644
index 0000000..a5496bd
--- /dev/null
+++ b/extensions/Wikibase/repo/i18n/arz.json
@@ -0,0 +1,9 @@
+{
+ "@metadata": {
+ "authors": [
+ "Ghaly"
+ ]
+ },
+ "wikibase-edit": "تعديل",
+ "wikibase-add": "ضيف"
+}
diff --git a/extensions/Wikibase/repo/i18n/km.json
b/extensions/Wikibase/repo/i18n/km.json
index 56230af..f19f88a 100644
--- a/extensions/Wikibase/repo/i18n/km.json
+++ b/extensions/Wikibase/repo/i18n/km.json
@@ -8,6 +8,9 @@
"wikibase-edit": "កែប្រែ",
"wikibase-add": "បន្ថែម",
"wikibase-addreference": "បន្ថែមឯកសារយោង",
+ "wikibase-entitytermsview-entitytermsforlanguagelistview-toggler":
"ជាភាសាដទៃទៀត",
+ "wikibase-entitytermsforlanguagelistview-language": "ភាសា",
+ "wikibase-terms": "ជាភាសាដទៃទៀត",
"wikibase-sitelinks-special": "វិបសាយផ្សេងទៀត",
"wikibase-statementview-referencesheading-pendingcountersubject":
"{{PLURAL:$1|ឯកសារយោង|ឯកសារយោង}}",
"wikibase-statementview-referencesheading-pendingcountertooltip":
"មិនទាន់បានរក្សាទុក {{PLURAL:$1|ឯកសារយោងមួយ|ឯកសារយោង $1}}"
diff --git a/extensions/Wikibase/repo/includes/api/EditEntity.php
b/extensions/Wikibase/repo/includes/api/EditEntity.php
index ca3c2a8..dda8d4e 100644
--- a/extensions/Wikibase/repo/includes/api/EditEntity.php
+++ b/extensions/Wikibase/repo/includes/api/EditEntity.php
@@ -288,14 +288,17 @@
// for more efficient validation!
if ( array_key_exists( 'labels', $data ) ) {
+ $this->assertArray( $data['labels'], 'List of labels
must be an array' );
$changeOps->add( $this->getLabelChangeOps(
$data['labels'] ) );
}
if ( array_key_exists( 'descriptions', $data ) ) {
+ $this->assertArray( $data['descriptions'], 'List of
descriptions must be an array' );
$changeOps->add( $this->getDescriptionChangeOps(
$data['descriptions'] ) );
}
if ( array_key_exists( 'aliases', $data ) ) {
+ $this->assertArray( $data['aliases'], 'List of aliases
must be an array' );
$changeOps->add( $this->getAliasesChangeOps(
$data['aliases'] ) );
}
@@ -303,14 +306,13 @@
if ( !( $entity instanceof Item ) ) {
$this->errorReporter->dieError( 'Non Items
cannot have sitelinks', 'not-recognized' );
}
-
+ $this->assertArray( $data['sitelinks'], 'List of
sitelinks must be an array' );
$changeOps->add( $this->getSiteLinksChangeOps(
$data['sitelinks'], $entity ) );
}
if ( array_key_exists( 'claims', $data ) ) {
- $changeOps->add(
- $this->getClaimsChangeOps( $data['claims'] )
- );
+ $this->assertArray( $data['claims'], 'List of claims
must be an array' );
+ $changeOps->add( $this->getClaimsChangeOps(
$data['claims'] ) );
}
return $changeOps;
@@ -321,12 +323,8 @@
*
* @return ChangeOp[]
*/
- private function getLabelChangeOps( $labels ) {
+ private function getLabelChangeOps( array $labels ) {
$labelChangeOps = array();
-
- if ( !is_array( $labels ) ) {
- $this->errorReporter->dieError( "List of labels must be
an array", 'not-recognized-array' );
- }
foreach ( $labels as $langCode => $arg ) {
$this->validateMultilangArgs( $arg, $langCode );
@@ -350,12 +348,8 @@
*
* @return ChangeOp[]
*/
- private function getDescriptionChangeOps( $descriptions ) {
+ private function getDescriptionChangeOps( array $descriptions ) {
$descriptionChangeOps = array();
-
- if ( !is_array( $descriptions ) ) {
- $this->errorReporter->dieError( "List of descriptions
must be an array", 'not-recognized-array' );
- }
foreach ( $descriptions as $langCode => $arg ) {
$this->validateMultilangArgs( $arg, $langCode );
@@ -379,11 +373,7 @@
*
* @return ChangeOp[]
*/
- private function getAliasesChangeOps( $aliases ) {
- if ( !is_array( $aliases ) ) {
- $this->errorReporter->dieError( "List of aliases must
be an array", 'not-recognized-array' );
- }
-
+ private function getAliasesChangeOps( array $aliases ) {
$indexedAliases = $this->getIndexedAliases( $aliases );
$aliasesChangeOps = $this->getIndexedAliasesChangeOps(
$indexedAliases );
@@ -449,13 +439,8 @@
*
* @return ChangeOp[]
*/
- private function getSiteLinksChangeOps( $siteLinks, Item $item ) {
+ private function getSiteLinksChangeOps( array $siteLinks, Item $item ) {
$siteLinksChangeOps = array();
-
- if ( !is_array( $siteLinks ) ) {
- $this->errorReporter->dieError( 'List of sitelinks must
be an array', 'not-recognized-array' );
- }
-
$sites = $this->siteLinkTargetProvider->getSiteList(
$this->siteLinkGroups );
foreach ( $siteLinks as $siteId => $arg ) {
@@ -508,10 +493,7 @@
*
* @return ChangeOp[]
*/
- private function getClaimsChangeOps( $claims ) {
- if ( !is_array( $claims ) ) {
- $this->errorReporter->dieError( "List of claims must be
an array", 'not-recognized-array' );
- }
+ private function getClaimsChangeOps( array $claims ) {
$changeOps = array();
//check if the array is associative or in arrays by property
@@ -659,14 +641,11 @@
}
// NOTE: json_decode will decode any JS literal or structure,
not just objects!
- if ( !is_array( $data ) ) {
- $this->errorReporter->dieError( 'Top level structure
must be a JSON object', 'not-recognized-array' );
- }
+ $this->assertArray( $data, 'Top level structure must be a JSON
object' );
foreach ( $data as $prop => $args ) {
- if ( !is_string( $prop ) ) { // NOTE: catch json_decode
returning an indexed array (list)
- $this->errorReporter->dieError( 'Top level
structure must be a JSON object, (no keys found)', 'not-recognized-string' );
- }
+ // Catch json_decode returning an indexed array (list).
+ $this->assertString( $prop, 'Top level structure must
be a JSON object (no keys found)' );
if ( !in_array( $prop, $allowedProps ) ) {
$this->errorReporter->dieError( "Unknown key in
json: $prop", 'not-recognized' );
@@ -848,27 +827,21 @@
* @param string $langCode The language code used in the value part
*/
private function validateMultilangArgs( $arg, $langCode ) {
- if ( !is_array( $arg ) ) {
- $this->errorReporter->dieError(
- "An array was expected, but not found in the
json for the langCode {$langCode}",
- 'not-recognized-array' );
- }
+ $this->assertArray( $arg, 'An array was expected, but not found
in the json for the '
+ . "langCode $langCode" );
if ( !array_key_exists( 'language', $arg ) ) {
$this->errorReporter->dieError(
- "'language' was not found in the label or
description json for {$langCode}",
+ "'language' was not found in the label or
description json for $langCode",
'missing-language' );
}
- if ( !is_string( $arg['language'] ) ) {
- $this->errorReporter->dieError(
- "A string was expected, but not found in the
json for the langCode {$langCode} and argument 'language'",
- 'not-recognized-string' );
- }
+ $this->assertString( $arg['language'], 'A string was expected,
but not found in the json '
+ . "for the langCode $langCode and argument 'language'"
);
if ( !is_numeric( $langCode ) ) {
if ( $langCode !== $arg['language'] ) {
$this->errorReporter->dieError(
- "inconsistent language: {$langCode} is
not equal to {$arg['language']}",
+ "inconsistent language: $langCode is
not equal to {$arg['language']}",
'inconsistent-language' );
}
}
@@ -877,10 +850,9 @@
$this->errorReporter->dieError( 'Unknown language: ' .
$arg['language'], 'not-recognized-language' );
}
- if ( !array_key_exists( 'remove', $arg ) && !is_string(
$arg['value'] ) ) {
- $this->errorReporter->dieError(
- "A string was expected, but not found in the
json for the langCode {$langCode} and argument 'value'",
- 'not-recognized-string' );
+ if ( !array_key_exists( 'remove', $arg ) ) {
+ $this->assertString( $arg['value'], 'A string was
expected, but not found in the json '
+ . "for the langCode $langCode and argument
'value'" );
}
}
@@ -892,34 +864,56 @@
* @param SiteList|null $sites The valid sites.
*/
private function checkSiteLinks( $arg, $siteCode, SiteList &$sites =
null ) {
- if ( !is_array( $arg ) ) {
- $this->errorReporter->dieError( 'An array was expected,
but not found', 'not-recognized-array' );
- }
- if ( !is_string( $arg['site'] ) ) {
- $this->errorReporter->dieError( 'A string was expected,
but not found', 'not-recognized-string' );
- }
+ $this->assertArray( $arg, 'An array was expected, but not
found' );
+ $this->assertString( $arg['site'], 'A string was expected, but
not found' );
+
if ( !is_numeric( $siteCode ) ) {
if ( $siteCode !== $arg['site'] ) {
- $this->errorReporter->dieError( "inconsistent
site: {$siteCode} is not equal to {$arg['site']}", 'inconsistent-site' );
+ $this->errorReporter->dieError( "inconsistent
site: $siteCode is not equal to {$arg['site']}", 'inconsistent-site' );
}
}
+
if ( $sites !== null && !$sites->hasSite( $arg['site'] ) ) {
$this->errorReporter->dieError( 'Unknown site: ' .
$arg['site'], 'not-recognized-site' );
}
- if ( isset( $arg['title'] ) && !is_string( $arg['title'] ) ) {
- $this->errorReporter->dieError( 'A string was expected,
but not found', 'not-recognized-string' );
+
+ if ( isset( $arg['title'] ) ) {
+ $this->assertString( $arg['title'], 'A string was
expected, but not found' );
}
+
if ( isset( $arg['badges'] ) ) {
- if ( !is_array( $arg['badges'] ) ) {
- $this->errorReporter->dieError( 'Badges: an
array was expected, but not found', 'not-recognized-array' );
- } else {
- foreach ( $arg['badges'] as $badge ) {
- if ( !is_string( $badge ) ) {
- $this->errorReporter->dieError(
'Badges: a string was expected, but not found', 'not-recognized-string' );
- }
- }
+ $this->assertArray( $arg['badges'], 'Badges: an array
was expected, but not found' );
+ foreach ( $arg['badges'] as $badge ) {
+ $this->assertString( $badge, 'Badges: a string
was expected, but not found' );
}
}
}
+ /**
+ * @param mixed $value
+ * @param string $message
+ */
+ private function assertArray( $value, $message ) {
+ $this->assertType( 'array', $value, $message );
+ }
+
+ /**
+ * @param mixed $value
+ * @param string $message
+ */
+ private function assertString( $value, $message ) {
+ $this->assertType( 'string', $value, $message );
+ }
+
+ /**
+ * @param string $type
+ * @param mixed $value
+ * @param string $message
+ */
+ private function assertType( $type, $value, $message ) {
+ if ( gettype( $value ) !== $type ) {
+ $this->errorReporter->dieError( $message,
'not-recognized-' . $type );
+ }
+ }
+
}
diff --git a/extensions/Wikibase/repo/includes/api/ItemByTitleHelper.php
b/extensions/Wikibase/repo/includes/api/ItemByTitleHelper.php
index 7681176..87e503d 100644
--- a/extensions/Wikibase/repo/includes/api/ItemByTitleHelper.php
+++ b/extensions/Wikibase/repo/includes/api/ItemByTitleHelper.php
@@ -66,7 +66,7 @@
* @param bool $normalize
*
* @throws UsageException
- * @return array( ItemId[], array() )
+ * @return array( ItemId[], array[] )
* List containing valid ItemIds and MissingItem site title
combinations
*/
public function getItemIds( array $sites, array $titles, $normalize ) {
diff --git
a/extensions/Wikibase/repo/includes/specials/SpecialGoToLinkedPage.php
b/extensions/Wikibase/repo/includes/specials/SpecialGoToLinkedPage.php
index e5937f9..41654d8 100644
--- a/extensions/Wikibase/repo/includes/specials/SpecialGoToLinkedPage.php
+++ b/extensions/Wikibase/repo/includes/specials/SpecialGoToLinkedPage.php
@@ -225,11 +225,9 @@
protected function outputForm( $site, $itemString ) {
$this->getOutput()->addModules(
'wikibase.special.goToLinkedPage' );
- // The message for the fieldset's legend is
<wikibase-gotolinkedpage-lookup-fieldset>
$formDescriptor = array(
'site' => array(
'name' => 'site',
- 'section' => 'gotolinkedpage-lookup-fieldset',
'default' => $site ?: '',
'type' => 'text',
'id' => 'wb-gotolinkedpage-sitename',
@@ -238,7 +236,6 @@
),
'itemid' => array(
'name' => 'itemid',
- 'section' => 'gotolinkedpage-lookup-fieldset',
'default' => $itemString ?: '',
'type' => 'text',
'id' => 'wb-gotolinkedpage-itemid',
@@ -248,7 +245,6 @@
),
'submit' => array(
'name' => 'submit',
- 'section' => 'gotolinkedpage-lookup-fieldset',
'default' => $this->msg(
'wikibase-gotolinkedpage-submit' )->text(),
'type' => 'submit',
'id' => 'wb-gotolinkedpage-submit',
@@ -256,9 +252,10 @@
)
);
- HTMLForm::factory( 'inline', $formDescriptor,
$this->getContext(), 'wikibase' )
+ HTMLForm::factory( 'inline', $formDescriptor,
$this->getContext() )
->setId( 'wb-gotolinkedpage-form1' )
->setMethod( 'get' )
+ ->setWrapperLegendMsg(
'wikibase-gotolinkedpage-lookup-fieldset' )
->suppressDefaultSubmit()
->setSubmitCallback( function () {// no-op
} )->show();
diff --git
a/extensions/Wikibase/repo/resources/wikibase.special/wikibase.special.itemByTitle.js
b/extensions/Wikibase/repo/resources/wikibase.special/wikibase.special.itemByTitle.js
index 3801368..5ea4d7b 100644
---
a/extensions/Wikibase/repo/resources/wikibase.special/wikibase.special.itemByTitle.js
+++
b/extensions/Wikibase/repo/resources/wikibase.special/wikibase.special.itemByTitle.js
@@ -15,10 +15,12 @@
}
// this will build a drop-down for the language selection:
- var siteList = [];
- for( var siteId in wb.sites.getSites() ) {
- var site = wb.sites.getSite( siteId );
- siteList.push( site.getName() + ' (' + site.getId() +
')' );
+ var sites = wb.sites.getSites(),
+ siteList = [];
+ for( var siteId in sites ) {
+ if( sites.hasOwnProperty( siteId ) ) {
+ siteList.push( sites[ siteId ].getName() + ' ('
+ siteId + ')' );
+ }
}
$( '#wb-itembytitle-sitename' )
.attr( 'autocomplete', 'off' )
diff --git a/vendor/composer/installed.json b/vendor/composer/installed.json
index a6057df..9f6f606 100644
--- a/vendor/composer/installed.json
+++ b/vendor/composer/installed.json
@@ -1279,12 +1279,12 @@
"source": {
"type": "git",
"url":
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git";,
- "reference": "ab33b656d538b4bd0faec99d9e82ce0eda28cda5"
+ "reference": "adf606c3fb089e4045614d344a0627ccf08c82e5"
},
"dist": {
"type": "zip",
- "url":
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/ab33b656d538b4bd0faec99d9e82ce0eda28cda5";,
- "reference": "ab33b656d538b4bd0faec99d9e82ce0eda28cda5",
+ "url":
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/adf606c3fb089e4045614d344a0627ccf08c82e5";,
+ "reference": "adf606c3fb089e4045614d344a0627ccf08c82e5",
"shasum": ""
},
"require": {
@@ -1315,7 +1315,7 @@
"require-dev": {
"squizlabs/php_codesniffer": "~2.1"
},
- "time": "2015-08-29 19:47:55",
+ "time": "2015-08-31 09:47:38",
"type": "mediawiki-extension",
"installation-source": "dist",
"autoload": {
--
To view, visit https://gerrit.wikimedia.org/r/234970
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0fd6f77dde4e45337cdd3dabcddbd872da12c42
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikidata
Gerrit-Branch: master
Gerrit-Owner: WikidataBuilder <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: JanZerebecki <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
