Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/235050
Change subject: Generate a new token for each survey
......................................................................
Generate a new token for each survey
Be consistent about creating tokens. Otherwise, a user would have
the same token for all existing surveys and different tokens for future
ones. This ensures that all surveys are seperated rather than grouped.
Change-Id: Ie9fc11ef843e9573bc5ee84bae8a40cca65a128f
---
M resources/ext.quicksurveys.init/init.js
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/QuickSurveys
refs/changes/50/235050/1
diff --git a/resources/ext.quicksurveys.init/init.js
b/resources/ext.quicksurveys.init/init.js
index d180eda..dcb5300 100644
--- a/resources/ext.quicksurveys.init/init.js
+++ b/resources/ext.quicksurveys.init/init.js
@@ -3,8 +3,7 @@
$panel = $( '<div class="ext-qs-loader-bar
mw-ajax-loader"></div>' ),
availableSurveys = mw.config.get( 'wgEnabledQuickSurveys' ),
isMainPage = mw.config.get( 'wgIsMainPage' ),
- isArticle = mw.config.get( 'wgIsArticle' ),
- sessionId = mw.user.generateRandomSessionId();
+ isArticle = mw.config.get( 'wgIsArticle' );
mw.extQuickSurveys = mw.extQuickSurveys || {};
@@ -79,7 +78,8 @@
token = getSurveyToken( survey );
if ( !token ) {
- token = sessionId;
+ // Generate a new token for each survey
+ token = mw.user.generateRandomSessionId();
mw.storage.set( storageId, token );
}
return mw.experiments.getBucket( {
--
To view, visit https://gerrit.wikimedia.org/r/235050
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9fc11ef843e9573bc5ee84bae8a40cca65a128f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/QuickSurveys
Gerrit-Branch: dev
Gerrit-Owner: Robmoen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
