Divec has uploaded a new change for review.
https://gerrit.wikimedia.org/r/235054
Change subject: Don't call setInsertionAnnotations on handleInsertion
......................................................................
Don't call setInsertionAnnotations on handleInsertion
It seems this code is obselete since f81b99026c59ba62b0764a402c4fffdc10379223
(which determines
annotations from context more carefully).
Change-Id: I5085400090dc81d1b9c6c56673d4905857a1ae52
---
M src/ce/ve.ce.Surface.js
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/54/235054/1
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index 0adf5fb..d7ec3df 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -3379,7 +3379,6 @@
this.model.setSelection( cellSelection );
this.handleTableDelete();
this.documentView.getBranchNodeFromOffset(
selection.tableRange.start + 1 ).setEditing( true );
- this.model.setInsertionAnnotations( annotations );
selection = this.model.getSelection();
}
@@ -3407,7 +3406,6 @@
this.surfaceObserver.clear();
range = this.model.getSelection().getRange();
}
- this.model.setInsertionAnnotations( annotations );
}
if ( hasChanged ) {
--
To view, visit https://gerrit.wikimedia.org/r/235054
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5085400090dc81d1b9c6c56673d4905857a1ae52
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Divec <da...@troi.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
