jenkins-bot has submitted this change and it was merged.
Change subject: MWReferenceNode: Don't allow cross-VE paste of template-defined
ref
......................................................................
MWReferenceNode: Don't allow cross-VE paste of template-defined ref
The reference body is not available, so it would be useless.
Bug: T110479
Change-Id: I2a40178bc629ca65d7507feb1c5ff062fd591eda
---
M modules/ve-mw/dm/nodes/ve.dm.MWReferenceNode.js
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/dm/nodes/ve.dm.MWReferenceNode.js
b/modules/ve-mw/dm/nodes/ve.dm.MWReferenceNode.js
index dc708c8..08d5362 100644
--- a/modules/ve-mw/dm/nodes/ve.dm.MWReferenceNode.js
+++ b/modules/ve-mw/dm/nodes/ve.dm.MWReferenceNode.js
@@ -171,6 +171,12 @@
}
}
+ // If we have no internal item data for this reference, don't let it
get pasted into
+ // another VE document. T110479
+ if ( isForClipboard && itemNodeRange.isCollapsed() ) {
+ el.setAttribute( 'data-ve-ignore', 'true' );
+ }
+
// Generate name
listKeyParts = dataElement.attributes.listKey.match( this.listKeyRegex
);
if ( listKeyParts[ 1 ] === 'auto' ) {
--
To view, visit https://gerrit.wikimedia.org/r/234408
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a40178bc629ca65d7507feb1c5ff062fd591eda
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
