jenkins-bot has submitted this change and it was merged.
Change subject: simplify HTMLParser
......................................................................
simplify HTMLParser
Remove the defaultdict from HTMLParser.handle_starttag
Change-Id: Ic256e19460e3601d259f98717b34b52947a62776
---
M pywikibot/site_detect.py
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/site_detect.py b/pywikibot/site_detect.py
index 0c66f9a..fed1f56 100644
--- a/pywikibot/site_detect.py
+++ b/pywikibot/site_detect.py
@@ -13,7 +13,6 @@
import json
import re
-from collections import defaultdict
from distutils.version import LooseVersion as V
from pywikibot.comms.http import fetch
@@ -131,10 +130,10 @@
self.generator = None
def handle_starttag(self, tag, attrs):
- attrs = defaultdict(lambda: None, attrs)
+ attrs = dict(attrs)
if tag == "meta":
- if attrs["name"] == "generator":
+ if attrs.get('name') == 'generator':
self.generator = attrs["content"]
if tag == "link":
- if attrs["rel"] == "EditURI":
+ if attrs.get('rel') == 'EditURI':
self.edituri = attrs["href"]
--
To view, visit https://gerrit.wikimedia.org/r/235191
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic256e19460e3601d259f98717b34b52947a62776
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jay...@gmail.com>
Gerrit-Reviewer: John Vandenberg <jay...@gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Maverick <manpreetkaur9...@gmail.com>
Gerrit-Reviewer: Xqt <i...@gno.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
