jenkins-bot has submitted this change and it was merged.
Change subject: Remove "submit=Search" from Special:ItemByTitle
......................................................................
Remove "submit=Search" from Special:ItemByTitle
By emptying the "name" attribute of the submit button
Bug: T96036
Change-Id: I4cd844cb68cd95029556163c159c00c65ac9efdc
---
M repo/includes/specials/SpecialItemByTitle.php
M repo/tests/phpunit/includes/specials/SpecialItemByTitleTest.php
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Bene: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/specials/SpecialItemByTitle.php
b/repo/includes/specials/SpecialItemByTitle.php
index 8aeab61..23289ea 100644
--- a/repo/includes/specials/SpecialItemByTitle.php
+++ b/repo/includes/specials/SpecialItemByTitle.php
@@ -227,7 +227,7 @@
)
)
. Html::input(
- 'submit',
+ '',
$this->msg( 'wikibase-itembytitle-submit'
)->text(),
'submit',
array(
diff --git a/repo/tests/phpunit/includes/specials/SpecialItemByTitleTest.php
b/repo/tests/phpunit/includes/specials/SpecialItemByTitleTest.php
index cb3816f..34eec76 100644
--- a/repo/tests/phpunit/includes/specials/SpecialItemByTitleTest.php
+++ b/repo/tests/phpunit/includes/specials/SpecialItemByTitleTest.php
@@ -130,7 +130,7 @@
'id' => 'wb-itembytitle-submit',
'class' => 'wb-button',
'type' => 'submit',
- 'name' => 'submit',
+ 'name' => '',
) );
$cases['empty'] = array( '', null, $matchers );
--
To view, visit https://gerrit.wikimedia.org/r/235080
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4cd844cb68cd95029556163c159c00c65ac9efdc
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Bene <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
