Subramanya Sastry has uploaded a new change for review. Change subject: Serializer bug fix for auto-inserted start/end tags. ......................................................................
Serializer bug fix for auto-inserted start/end tags. * For auto-inserted start/end tags, only the output needs to be suppressed. The handler itself needs to run as usual so that serialize state is updated properly. * Encountered this bug investigating strange RT errors in en:Anwar Nasser Abdulla Aulaqi which is captured in the following test case: --------- <blockquote> :a :b</blockquote> c --------- This wraps the c in p-tags during serialization which can be reduced to the fact that the </dd> tag for ":b" has autoInsertedEnd set to true (which is a separate "bug" worth investigating because adding a newline after :b before </blockquote> prevents that flag from being set). In turn, the </dd> handler does not run which does not clear the singleLineMode which causes the p-handler to use a generic-html-tag serializer in singleLineMode (which is odd as well and worthy of investigation independently). * No change in parserTests (regular as well as selective serializer) But, change in output of a failed test which is traceable to the fact that token-collector-handlers (ex: link-handler) dont deal with autoInsertedStart/End flags -- added a FIXME for this for now. * Fixes all weird semantic errors in en:Anwar Nasser Abdulla Aulaqi Change-Id: I1a0308ddc0b93e16c6ec80526540daa745c7c3fa --- M js/lib/mediawiki.WikitextSerializer.js 1 file changed, 24 insertions(+), 16 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/82/37782/1 -- To view, visit https://gerrit.wikimedia.org/r/37782 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1a0308ddc0b93e16c6ec80526540daa745c7c3fa Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
