jenkins-bot has submitted this change and it was merged.
Change subject: Avoid PHP notices on undefined timed_out response
......................................................................
Avoid PHP notices on undefined timed_out response
Change-Id: Ie21d03671aa1659447e53a0cd1315e7cf3e5f26c
---
M includes/Searcher.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
Objections:
Cindy-the-browser-test-bot: There's a problem with this change, please improve
diff --git a/includes/Searcher.php b/includes/Searcher.php
index a95590e..befed88 100644
--- a/includes/Searcher.php
+++ b/includes/Searcher.php
@@ -1499,7 +1499,7 @@
$result->setResult( true,
$this->resultsType->transformElasticsearchResult( $this->suggestPrefixes,
$this->suggestSuffixes, $result->getValue(),
$this->searchContainedSyntax ) );
- if ( $responseData[ 'timed_out' ] ) {
+ if ( isset( $responseData['timed_out'] ) &&
$responseData[ 'timed_out' ] ) {
LoggerFactory::getInstance( 'CirrusSearch'
)->warning(
"$description timed out and only
returned partial results!",
$logContext
--
To view, visit https://gerrit.wikimedia.org/r/235355
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie21d03671aa1659447e53a0cd1315e7cf3e5f26c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: MarkAHershberger <m...@nichework.com>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Cindy-the-browser-test-bot <bernhardsone...@gmail.com>
Gerrit-Reviewer: DCausse <dcau...@wikimedia.org>
Gerrit-Reviewer: Manybubbles <never...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
