jenkins-bot has submitted this change and it was merged.
Change subject: Exit early from parse.js if selsering w/o source
......................................................................
Exit early from parse.js if selsering w/o source
Change-Id: I356649bff7e62997298c8cb454c13a2fa698d8cc
---
M tests/parse.js
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/parse.js b/tests/parse.js
index f014900..de63f16 100755
--- a/tests/parse.js
+++ b/tests/parse.js
@@ -73,7 +73,7 @@
'oldtext': {
description: 'The old page text for a selective-serialization
(see --selser)',
'boolean': false,
- 'default': false,
+ 'default': null,
},
'oldtextfile': {
description: 'File containing the old page text for a
selective-serialization (see --selser)',
@@ -231,6 +231,11 @@
env.setPageSrcInfo(argv.oldtext || null);
}
+ if (argv.selser && argv.oldtext === null) {
+ throw new Error('Please provide original wikitext ' +
+ '(--oldtext or --oldtextfile). Selser requires
that.');
+ }
+
if (typeof (input) === 'string') {
return { env: env, input: input };
}
--
To view, visit https://gerrit.wikimedia.org/r/235349
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I356649bff7e62997298c8cb454c13a2fa698d8cc
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <abrea...@wikimedia.org>
Gerrit-Reviewer: Subramanya Sastry <ssas...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
