jenkins-bot has submitted this change and it was merged.

Change subject: Reword 'stub-threshold' message in Special:Preferences advanced 
section
......................................................................


Reword 'stub-threshold' message in Special:Preferences advanced section

Message changed from "Threshold for stub link formatting bytes" to
"Threshold in bytes for stub link rendering (sample)".

Also convert it to a wikitext message (not raw HTML) and improve the "qqq"
documentation.

Bug: T107732
Change-Id: I493679073b9881c98a068dede2db00b391ab8353
---
M includes/Preferences.php
M languages/i18n/en.json
M languages/i18n/qqq.json
3 files changed, 9 insertions(+), 3 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Preferences.php b/includes/Preferences.php
index fbb7b51..6f95952 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -751,7 +751,11 @@
                        'type' => 'select',
                        'section' => 'rendering/advancedrendering',
                        'options' => $stubThresholdOptions,
-                       'label-raw' => $context->msg( 'stub-threshold' 
)->text(), // Raw HTML message. Yay?
+                       // This is not a raw HTML message; label-raw is needed 
for the manual <a></a>
+                       'label-raw' => $context->msg( 'stub-threshold' 
)->rawParams(
+                               '<a href="#" class="stub">' .
+                               $context->msg( 'stub-threshold-sample-link' 
)->parse() .
+                               '</a>' )->parse(),
                );
 
                $defaultPreferences['showhiddencats'] = array(
diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index 681d63e..7703f7b 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -975,7 +975,8 @@
        "rows": "Rows:",
        "columns": "Columns:",
        "searchresultshead": "Search",
-       "stub-threshold": "Threshold for <a href=\"#\" class=\"stub\">stub 
link</a> formatting (bytes):",
+       "stub-threshold": "Threshold for stub link formatting ($1):",
+       "stub-threshold-sample-link": "sample",
        "stub-threshold-disabled": "Disabled",
        "recentchangesdays": "Days to show in recent changes:",
        "recentchangesdays-max": "Maximum $1 {{PLURAL:$1|day|days}}",
diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json
index e011dd7..a983bba 100644
--- a/languages/i18n/qqq.json
+++ b/languages/i18n/qqq.json
@@ -1146,7 +1146,8 @@
        "rows": "Used on [[Special:Preferences]], \"Editing\" section in the 
\"Size of editing window\" fieldset.\n{{Identical|Row}}",
        "columns": "Used on [[Special:Preferences]], \"Editing\" section in the 
\"Size of editing window\" fieldset.\n{{Identical|Column}}",
        "searchresultshead": "Replaced by {{msg-mw|prefs-searchoptions}}, 
though may still be used in some extensions. 
DEPRECATED.\n\n{{Identical|Search}}",
-       "stub-threshold": "Used in [[Special:Preferences]], tab \"Misc\".",
+       "stub-threshold": "Used in [[Special:Preferences]], \"Advanced 
options\" section. The setting allows the user to select a threshold value, in 
bytes, from a predefined list of options. Any links that lead to pages smaller 
than the threshold (\"stub links\") will be styled 
differently.\n\nParameters:\n* $1: the text of 
{{msg-mw|stub-threshold-sample-link}}, styled as a stub link",
+       "stub-threshold-sample-link": "Passed as a parameter to the 
{{msg-mw|stub-threshold}} message.",
        "stub-threshold-disabled": "Used in 
[[Special:Preferences]].\n{{Identical|Disabled}}",
        "recentchangesdays": "Used in [[Special:Preferences]], tab \"Recent 
changes\".",
        "recentchangesdays-max": "Shown as hint in [[Special:Preferences]], tab 
\"Recent changes\". Parameters:\n* $1 - number of days\nSee also:\n* 
{{msg-mw|Prefs-watchlist-days-max}}",

-- 
To view, visit https://gerrit.wikimedia.org/r/230288
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I493679073b9881c98a068dede2db00b391ab8353
Gerrit-PatchSet: 8
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Devirk <[email protected]>
Gerrit-Reviewer: 01tonythomas <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: TTO <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to