Ori.livneh has submitted this change and it was merged.
Change subject: Lint!
......................................................................
Lint!
- Whitespace
+ One empty line before a class's first method.
+ Two empty lines before any other method or function.
+ Three empty lines between major sections.
- File names
+ Rename: 'content' => 'includes'.
+ Move RemoteSchema and ResourceLoaderSchemaModule to 'includes'.
- Comment style
+ Line width: 72 characters (but fungible in specific cases).
+ Tense: present simple ('puts', 'gets', etc.).
+ English prose terminates with a period.
- Doxygen syntax
+ @param type $varname: Description.
+ No empty lines in trivial comment blocks.
- Multi-line arrays declarations: trailing comma after final item.
Change-Id: I04d90a1790a433c5f220518b6ab1110da3aabff0
---
M EventLogging.hooks.php
M EventLogging.php
D content/JsonSchemaHooks.php
R includes/JsonSchemaContent.php
R includes/JsonSchemaContentHandler.php
A includes/JsonSchemaHooks.php
R includes/RemoteSchema.php
R includes/ResourceLoaderSchemaModule.php
M modules/ext.eventLogging.core.js
M scripts/DevServer.php
M tests/JsonSchemaTest.php
M tests/RemoteSchemaTest.php
M tests/ResourceLoaderSchemaModuleTest.php
13 files changed, 231 insertions(+), 224 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.wikimedia.org/r/37783
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04d90a1790a433c5f220518b6ab1110da3aabff0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
