Alexandros Kosiaris has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/235450

Change subject: apertium: fix typo errors
......................................................................

apertium: fix typo errors

* Use the correct $log_dir variable
* Add the missing ending double quotes in upstart directives

Change-Id: I585bc1f4f946675117412055a6bc1e772394551f
---
M modules/apertium/manifests/init.pp
M modules/apertium/templates/initscripts/apertium-apy.upstart.erb
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/50/235450/1

diff --git a/modules/apertium/manifests/init.pp 
b/modules/apertium/manifests/init.pp
index 68232d7..88b6a5c 100644
--- a/modules/apertium/manifests/init.pp
+++ b/modules/apertium/manifests/init.pp
@@ -84,7 +84,7 @@
         }
     }
 
-    file { $local_logdir:
+    file { $log_dir:
         ensure => directory,
         owner  => $uid,
         group  => 'root', # This on purpose for logrotate to behave
diff --git a/modules/apertium/templates/initscripts/apertium-apy.upstart.erb 
b/modules/apertium/templates/initscripts/apertium-apy.upstart.erb
index 88786c8..15c5069 100644
--- a/modules/apertium/templates/initscripts/apertium-apy.upstart.erb
+++ b/modules/apertium/templates/initscripts/apertium-apy.upstart.erb
@@ -7,8 +7,8 @@
 start on (local-filesystems and net-device-up IFACE!=lo)
 stop on runlevel [!2345]
 
-setuid "<%= @uid %>
-setgid "<%= @gid %>
+setuid "<%= @uid %>"
+setgid "<%= @gid %>"
 
 # Apertium seems to leak fds, or the current default limit is not enough
 limit nofile 8096 8096

-- 
To view, visit https://gerrit.wikimedia.org/r/235450
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I585bc1f4f946675117412055a6bc1e772394551f
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to