AndyRussG has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/235472

Change subject: Inline documentation for mw.centralNotice.getBucket
......................................................................

Inline documentation for mw.centralNotice.getBucket

Change-Id: I1ab86e65f9140ef2a31a01e765756c06529a67df
---
M resources/subscribing/ext.centralNotice.display.js
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice 
refs/changes/72/235472/1

diff --git a/resources/subscribing/ext.centralNotice.display.js 
b/resources/subscribing/ext.centralNotice.display.js
index ec45642..997b5ca 100644
--- a/resources/subscribing/ext.centralNotice.display.js
+++ b/resources/subscribing/ext.centralNotice.display.js
@@ -490,8 +490,14 @@
                        cn.hideBannerWithCloseButton();
                },
 
+               /**
+                * Set and store this user's bucket for the current campaign. 
The
+                * bucketer must be initialized first. However, code in 
campaign mixin
+                * hook handlers and banners can safely assume that's the case.
+                *
+                * The current bucket can be read from 
mw.centralNotice.data.bucket
+                */
                setBucket: function( bucket ) {
-                       // Note: we assume buckter has been initialized.
                        cn.internal.bucketer.setBucket( bucket );
                        cn.internal.state.setBucket( bucket );
                },

-- 
To view, visit https://gerrit.wikimedia.org/r/235472
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ab86e65f9140ef2a31a01e765756c06529a67df
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: AndyRussG <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to