Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/235478
Change subject: Fixed Style/StringLiterals RuboCop offense ...................................................................... Fixed Style/StringLiterals RuboCop offense Bug: T111184 Change-Id: Ia51f271b5e06d7bbd9896634b832003d57c30900 --- M .rubocop.yml D .rubocop_todo.yml M Gemfile M tests/browser/features/support/env.rb M tests/browser/features/support/pages/does_not_exist_page.rb M tests/browser/features/support/pages/edit_page.rb 6 files changed, 13 insertions(+), 29 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Math refs/changes/78/235478/1 diff --git a/.rubocop.yml b/.rubocop.yml index 10a7cc0..84567a5 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,5 +1,3 @@ -inherit_from: .rubocop_todo.yml - AllCops: StyleGuideCopsOnly: true @@ -15,9 +13,8 @@ Style/SignalException: Enabled: false -# TODO: uncomment when the time comes -# Style/StringLiterals: -# EnforcedStyle: single_quotes +Style/StringLiterals: + EnforcedStyle: single_quotes Style/TrivialAccessors: ExactNameMatch: true diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml deleted file mode 100644 index b572acb..0000000 --- a/.rubocop_todo.yml +++ /dev/null @@ -1,13 +0,0 @@ -# This configuration was generated by -# `rubocop --auto-gen-config` -# on 2015-09-02 17:15:05 +0200 using RuboCop version 0.33.0. -# The point is for the user to remove these configuration records -# one by one as the offenses are removed from the code base. -# Note that changes in the inspected code, or installation of new -# versions of RuboCop, may require this file to be generated again. - -# Offense count: 13 -# Cop supports --auto-correct. -# Configuration parameters: SupportedStyles. -Style/StringLiterals: - EnforcedStyle: double_quotes diff --git a/Gemfile b/Gemfile index 6834e17..e678630 100644 --- a/Gemfile +++ b/Gemfile @@ -1,4 +1,4 @@ -source "https://rubygems.org"; +source 'https://rubygems.org' -gem "mediawiki_selenium", "~> 1.5.0" -gem "rubocop", "~> 0.33.0", require: false +gem 'mediawiki_selenium', '~> 1.5.0' +gem 'rubocop', '~> 0.33.0', require: false diff --git a/tests/browser/features/support/env.rb b/tests/browser/features/support/env.rb index 57f3e6b..5eff4ce 100644 --- a/tests/browser/features/support/env.rb +++ b/tests/browser/features/support/env.rb @@ -1,4 +1,4 @@ -require "mediawiki_selenium" +require 'mediawiki_selenium' -require "mediawiki_selenium/support" -require "mediawiki_selenium/step_definitions" +require 'mediawiki_selenium/support' +require 'mediawiki_selenium/step_definitions' diff --git a/tests/browser/features/support/pages/does_not_exist_page.rb b/tests/browser/features/support/pages/does_not_exist_page.rb index e24b398..f3a58da 100644 --- a/tests/browser/features/support/pages/does_not_exist_page.rb +++ b/tests/browser/features/support/pages/does_not_exist_page.rb @@ -12,7 +12,7 @@ class DoesNotExistPage include PageObject - page_url "<%=params[:page_name]%>" + page_url '<%=params[:page_name]%>' - a(:create_source, text: "Create source") + a(:create_source, text: 'Create source') end diff --git a/tests/browser/features/support/pages/edit_page.rb b/tests/browser/features/support/pages/edit_page.rb index b0266bc..bfb6903 100644 --- a/tests/browser/features/support/pages/edit_page.rb +++ b/tests/browser/features/support/pages/edit_page.rb @@ -12,7 +12,7 @@ class EditPage include PageObject - text_area(:article_text, id: "wpTextbox1") - img(:math_image, class: "tex") - button(:preview, id: "wpPreview") + text_area(:article_text, id: 'wpTextbox1') + img(:math_image, class: 'tex') + button(:preview, id: 'wpPreview') end -- To view, visit https://gerrit.wikimedia.org/r/235478 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia51f271b5e06d7bbd9896634b832003d57c30900 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Math Gerrit-Branch: master Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
