Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/235488
Change subject: Remove LDPI assets ...................................................................... Remove LDPI assets * Remove all LDPI assets. * Remove LDPI support from convert-icons.py. It's hard to find LDPI devices these days. The actual LDPI usage metrics for the app aren't in the Play console but the global Dashboard[0] shows that the density comprises 3.9% of devices across all versions of Android. This patch removes LDPI targeted asset cuts and saves our users some bandwidth. [0] https://developer.android.com/about/dashboards/index.html#Screens Bug: T108861 Change-Id: I0db83a94f6dfe9baa9696a952168ad91852c9104 --- D app/src/main/res/drawable-ldpi/about_logo.png D app/src/main/res/drawable-ldpi/abusefilter_disallow.png D app/src/main/res/drawable-ldpi/abusefilter_warn.png D app/src/main/res/drawable-ldpi/bookmark_white.png D app/src/main/res/drawable-ldpi/cc_logo.png D app/src/main/res/drawable-ldpi/clock_white.png D app/src/main/res/drawable-ldpi/dice_white.png D app/src/main/res/drawable-ldpi/empty_nearby.png D app/src/main/res/drawable-ldpi/face_sleep_white.png D app/src/main/res/drawable-ldpi/face_smile_white.png D app/src/main/res/drawable-ldpi/facebook.png D app/src/main/res/drawable-ldpi/gear_white.png D app/src/main/res/drawable-ldpi/ic_add_tab.png D app/src/main/res/drawable-ldpi/ic_close_gray.png D app/src/main/res/drawable-ldpi/ic_close_white.png D app/src/main/res/drawable-ldpi/ic_delete.png D app/src/main/res/drawable-ldpi/ic_delete_grey.png D app/src/main/res/drawable-ldpi/ic_error_gray.png D app/src/main/res/drawable-ldpi/ic_expand_less_dark.png D app/src/main/res/drawable-ldpi/ic_expand_more_dark.png D app/src/main/res/drawable-ldpi/ic_flag.png D app/src/main/res/drawable-ldpi/ic_license_cc.png D app/src/main/res/drawable-ldpi/ic_license_cite.png D app/src/main/res/drawable-ldpi/ic_license_pd.png D app/src/main/res/drawable-ldpi/ic_more_vert.png D app/src/main/res/drawable-ldpi/ic_pageimage_placeholder.png D app/src/main/res/drawable-ldpi/ic_place.png D app/src/main/res/drawable-ldpi/ic_place_dark.png D app/src/main/res/drawable-ldpi/ic_refresh.png D app/src/main/res/drawable-ldpi/ic_search.png D app/src/main/res/drawable-ldpi/ic_share_dark.png D app/src/main/res/drawable-ldpi/ic_tab_list.png D app/src/main/res/drawable-ldpi/ic_toc.png D app/src/main/res/drawable-ldpi/ic_today.png D app/src/main/res/drawable-ldpi/ic_visibility_gray.png D app/src/main/res/drawable-ldpi/launcher.png D app/src/main/res/drawable-ldpi/messaging.png D app/src/main/res/drawable-ldpi/recent.png D app/src/main/res/drawable-ldpi/savedpages.png D app/src/main/res/drawable-ldpi/tool_tip_arrow_down.png D app/src/main/res/drawable-ldpi/tool_tip_arrow_up.png D app/src/main/res/drawable-ldpi/twitter.png D app/src/main/res/drawable-ldpi/wmf_logo.png D app/src/main/res/drawable-ldrtl-ldpi/bookmark_white.png D app/src/main/res/drawable-ldrtl-ldpi/clock_white.png D app/src/main/res/drawable-ldrtl-ldpi/dice_white.png D app/src/main/res/drawable-ldrtl-ldpi/face_sleep_white.png D app/src/main/res/drawable-ldrtl-ldpi/face_smile_white.png D app/src/main/res/drawable-ldrtl-ldpi/gear_white.png D app/src/main/res/drawable-ldrtl-ldpi/ic_flag.png D app/src/main/res/drawable-ldrtl-ldpi/ic_refresh.png D app/src/main/res/drawable-ldrtl-ldpi/ic_search.png D app/src/main/res/drawable-ldrtl-ldpi/ic_share_dark.png D app/src/main/res/drawable-ldrtl-ldpi/ic_toc.png D app/src/main/res/drawable-ldrtl-ldpi/ic_today.png D app/src/main/res/drawable-ldrtl-ldpi/wmf_logo.png M scripts/convert-icons.py 57 files changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/88/235488/1 diff --git a/app/src/main/res/drawable-ldpi/about_logo.png b/app/src/main/res/drawable-ldpi/about_logo.png deleted file mode 100644 index f1946cf..0000000 --- a/app/src/main/res/drawable-ldpi/about_logo.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/abusefilter_disallow.png b/app/src/main/res/drawable-ldpi/abusefilter_disallow.png deleted file mode 100644 index e42d09d..0000000 --- a/app/src/main/res/drawable-ldpi/abusefilter_disallow.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/abusefilter_warn.png b/app/src/main/res/drawable-ldpi/abusefilter_warn.png deleted file mode 100644 index ecbdcb7..0000000 --- a/app/src/main/res/drawable-ldpi/abusefilter_warn.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/bookmark_white.png b/app/src/main/res/drawable-ldpi/bookmark_white.png deleted file mode 100644 index 6bcefce..0000000 --- a/app/src/main/res/drawable-ldpi/bookmark_white.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/cc_logo.png b/app/src/main/res/drawable-ldpi/cc_logo.png deleted file mode 100644 index a4b3777..0000000 --- a/app/src/main/res/drawable-ldpi/cc_logo.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/clock_white.png b/app/src/main/res/drawable-ldpi/clock_white.png deleted file mode 100644 index 3d99e81..0000000 --- a/app/src/main/res/drawable-ldpi/clock_white.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/dice_white.png b/app/src/main/res/drawable-ldpi/dice_white.png deleted file mode 100644 index e8536c1..0000000 --- a/app/src/main/res/drawable-ldpi/dice_white.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/empty_nearby.png b/app/src/main/res/drawable-ldpi/empty_nearby.png deleted file mode 100644 index a4491f1..0000000 --- a/app/src/main/res/drawable-ldpi/empty_nearby.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/face_sleep_white.png b/app/src/main/res/drawable-ldpi/face_sleep_white.png deleted file mode 100644 index 891b6bf..0000000 --- a/app/src/main/res/drawable-ldpi/face_sleep_white.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/face_smile_white.png b/app/src/main/res/drawable-ldpi/face_smile_white.png deleted file mode 100644 index b668d2f..0000000 --- a/app/src/main/res/drawable-ldpi/face_smile_white.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/facebook.png b/app/src/main/res/drawable-ldpi/facebook.png deleted file mode 100644 index 67d71c0..0000000 --- a/app/src/main/res/drawable-ldpi/facebook.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/gear_white.png b/app/src/main/res/drawable-ldpi/gear_white.png deleted file mode 100644 index 828d808..0000000 --- a/app/src/main/res/drawable-ldpi/gear_white.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_add_tab.png b/app/src/main/res/drawable-ldpi/ic_add_tab.png deleted file mode 100644 index f9dd676..0000000 --- a/app/src/main/res/drawable-ldpi/ic_add_tab.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_close_gray.png b/app/src/main/res/drawable-ldpi/ic_close_gray.png deleted file mode 100644 index a0c4d03..0000000 --- a/app/src/main/res/drawable-ldpi/ic_close_gray.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_close_white.png b/app/src/main/res/drawable-ldpi/ic_close_white.png deleted file mode 100644 index f4695d2..0000000 --- a/app/src/main/res/drawable-ldpi/ic_close_white.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_delete.png b/app/src/main/res/drawable-ldpi/ic_delete.png deleted file mode 100644 index beb5f08..0000000 --- a/app/src/main/res/drawable-ldpi/ic_delete.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_delete_grey.png b/app/src/main/res/drawable-ldpi/ic_delete_grey.png deleted file mode 100644 index 133d9e1..0000000 --- a/app/src/main/res/drawable-ldpi/ic_delete_grey.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_error_gray.png b/app/src/main/res/drawable-ldpi/ic_error_gray.png deleted file mode 100644 index e0546fe..0000000 --- a/app/src/main/res/drawable-ldpi/ic_error_gray.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_expand_less_dark.png b/app/src/main/res/drawable-ldpi/ic_expand_less_dark.png deleted file mode 100644 index 706fcdb..0000000 --- a/app/src/main/res/drawable-ldpi/ic_expand_less_dark.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_expand_more_dark.png b/app/src/main/res/drawable-ldpi/ic_expand_more_dark.png deleted file mode 100644 index 2f9868b..0000000 --- a/app/src/main/res/drawable-ldpi/ic_expand_more_dark.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_flag.png b/app/src/main/res/drawable-ldpi/ic_flag.png deleted file mode 100644 index cdb2e7c..0000000 --- a/app/src/main/res/drawable-ldpi/ic_flag.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_license_cc.png b/app/src/main/res/drawable-ldpi/ic_license_cc.png deleted file mode 100644 index 7143cbc..0000000 --- a/app/src/main/res/drawable-ldpi/ic_license_cc.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_license_cite.png b/app/src/main/res/drawable-ldpi/ic_license_cite.png deleted file mode 100644 index e43ec21..0000000 --- a/app/src/main/res/drawable-ldpi/ic_license_cite.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_license_pd.png b/app/src/main/res/drawable-ldpi/ic_license_pd.png deleted file mode 100644 index 47f5feb..0000000 --- a/app/src/main/res/drawable-ldpi/ic_license_pd.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_more_vert.png b/app/src/main/res/drawable-ldpi/ic_more_vert.png deleted file mode 100644 index 80a6bdc..0000000 --- a/app/src/main/res/drawable-ldpi/ic_more_vert.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_pageimage_placeholder.png b/app/src/main/res/drawable-ldpi/ic_pageimage_placeholder.png deleted file mode 100644 index c196cda..0000000 --- a/app/src/main/res/drawable-ldpi/ic_pageimage_placeholder.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_place.png b/app/src/main/res/drawable-ldpi/ic_place.png deleted file mode 100644 index b91ee0e..0000000 --- a/app/src/main/res/drawable-ldpi/ic_place.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_place_dark.png b/app/src/main/res/drawable-ldpi/ic_place_dark.png deleted file mode 100644 index 087083c..0000000 --- a/app/src/main/res/drawable-ldpi/ic_place_dark.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_refresh.png b/app/src/main/res/drawable-ldpi/ic_refresh.png deleted file mode 100644 index 23fb199..0000000 --- a/app/src/main/res/drawable-ldpi/ic_refresh.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_search.png b/app/src/main/res/drawable-ldpi/ic_search.png deleted file mode 100644 index 410f6f0..0000000 --- a/app/src/main/res/drawable-ldpi/ic_search.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_share_dark.png b/app/src/main/res/drawable-ldpi/ic_share_dark.png deleted file mode 100644 index a4f0031..0000000 --- a/app/src/main/res/drawable-ldpi/ic_share_dark.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_tab_list.png b/app/src/main/res/drawable-ldpi/ic_tab_list.png deleted file mode 100644 index 527283f..0000000 --- a/app/src/main/res/drawable-ldpi/ic_tab_list.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_toc.png b/app/src/main/res/drawable-ldpi/ic_toc.png deleted file mode 100644 index 4699ff9..0000000 --- a/app/src/main/res/drawable-ldpi/ic_toc.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_today.png b/app/src/main/res/drawable-ldpi/ic_today.png deleted file mode 100644 index a3e54ac..0000000 --- a/app/src/main/res/drawable-ldpi/ic_today.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/ic_visibility_gray.png b/app/src/main/res/drawable-ldpi/ic_visibility_gray.png deleted file mode 100644 index 9897473..0000000 --- a/app/src/main/res/drawable-ldpi/ic_visibility_gray.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/launcher.png b/app/src/main/res/drawable-ldpi/launcher.png deleted file mode 100644 index dc811b4..0000000 --- a/app/src/main/res/drawable-ldpi/launcher.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/messaging.png b/app/src/main/res/drawable-ldpi/messaging.png deleted file mode 100644 index b115900..0000000 --- a/app/src/main/res/drawable-ldpi/messaging.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/recent.png b/app/src/main/res/drawable-ldpi/recent.png deleted file mode 100644 index 4a4f874..0000000 --- a/app/src/main/res/drawable-ldpi/recent.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/savedpages.png b/app/src/main/res/drawable-ldpi/savedpages.png deleted file mode 100644 index 4cd77ca..0000000 --- a/app/src/main/res/drawable-ldpi/savedpages.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/tool_tip_arrow_down.png b/app/src/main/res/drawable-ldpi/tool_tip_arrow_down.png deleted file mode 100644 index ee451d6..0000000 --- a/app/src/main/res/drawable-ldpi/tool_tip_arrow_down.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/tool_tip_arrow_up.png b/app/src/main/res/drawable-ldpi/tool_tip_arrow_up.png deleted file mode 100644 index a7441ff..0000000 --- a/app/src/main/res/drawable-ldpi/tool_tip_arrow_up.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/twitter.png b/app/src/main/res/drawable-ldpi/twitter.png deleted file mode 100644 index 0d95fc6..0000000 --- a/app/src/main/res/drawable-ldpi/twitter.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldpi/wmf_logo.png b/app/src/main/res/drawable-ldpi/wmf_logo.png deleted file mode 100644 index 9021a1a..0000000 --- a/app/src/main/res/drawable-ldpi/wmf_logo.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldrtl-ldpi/bookmark_white.png b/app/src/main/res/drawable-ldrtl-ldpi/bookmark_white.png deleted file mode 100644 index d45f007..0000000 --- a/app/src/main/res/drawable-ldrtl-ldpi/bookmark_white.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldrtl-ldpi/clock_white.png b/app/src/main/res/drawable-ldrtl-ldpi/clock_white.png deleted file mode 100644 index 8bfb56d..0000000 --- a/app/src/main/res/drawable-ldrtl-ldpi/clock_white.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldrtl-ldpi/dice_white.png b/app/src/main/res/drawable-ldrtl-ldpi/dice_white.png deleted file mode 100644 index aa1b49a..0000000 --- a/app/src/main/res/drawable-ldrtl-ldpi/dice_white.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldrtl-ldpi/face_sleep_white.png b/app/src/main/res/drawable-ldrtl-ldpi/face_sleep_white.png deleted file mode 100644 index aa900bc..0000000 --- a/app/src/main/res/drawable-ldrtl-ldpi/face_sleep_white.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldrtl-ldpi/face_smile_white.png b/app/src/main/res/drawable-ldrtl-ldpi/face_smile_white.png deleted file mode 100644 index 89165a1..0000000 --- a/app/src/main/res/drawable-ldrtl-ldpi/face_smile_white.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldrtl-ldpi/gear_white.png b/app/src/main/res/drawable-ldrtl-ldpi/gear_white.png deleted file mode 100644 index ae7a626..0000000 --- a/app/src/main/res/drawable-ldrtl-ldpi/gear_white.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldrtl-ldpi/ic_flag.png b/app/src/main/res/drawable-ldrtl-ldpi/ic_flag.png deleted file mode 100644 index 1f573fe..0000000 --- a/app/src/main/res/drawable-ldrtl-ldpi/ic_flag.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldrtl-ldpi/ic_refresh.png b/app/src/main/res/drawable-ldrtl-ldpi/ic_refresh.png deleted file mode 100644 index dd59807..0000000 --- a/app/src/main/res/drawable-ldrtl-ldpi/ic_refresh.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldrtl-ldpi/ic_search.png b/app/src/main/res/drawable-ldrtl-ldpi/ic_search.png deleted file mode 100644 index ad869e9..0000000 --- a/app/src/main/res/drawable-ldrtl-ldpi/ic_search.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldrtl-ldpi/ic_share_dark.png b/app/src/main/res/drawable-ldrtl-ldpi/ic_share_dark.png deleted file mode 100644 index d4469e1..0000000 --- a/app/src/main/res/drawable-ldrtl-ldpi/ic_share_dark.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldrtl-ldpi/ic_toc.png b/app/src/main/res/drawable-ldrtl-ldpi/ic_toc.png deleted file mode 100644 index 002a99f..0000000 --- a/app/src/main/res/drawable-ldrtl-ldpi/ic_toc.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldrtl-ldpi/ic_today.png b/app/src/main/res/drawable-ldrtl-ldpi/ic_today.png deleted file mode 100644 index 78c2fba..0000000 --- a/app/src/main/res/drawable-ldrtl-ldpi/ic_today.png +++ /dev/null Binary files differ diff --git a/app/src/main/res/drawable-ldrtl-ldpi/wmf_logo.png b/app/src/main/res/drawable-ldrtl-ldpi/wmf_logo.png deleted file mode 100644 index 08b2106..0000000 --- a/app/src/main/res/drawable-ldrtl-ldpi/wmf_logo.png +++ /dev/null Binary files differ diff --git a/scripts/convert-icons.py b/scripts/convert-icons.py index 38ed5ba..e318d60 100755 --- a/scripts/convert-icons.py +++ b/scripts/convert-icons.py @@ -5,7 +5,6 @@ from glob import glob DENSITIES = { - "ldpi": 0.75, "mdpi": 1, "hdpi": 1.5, "xhdpi": 2, -- To view, visit https://gerrit.wikimedia.org/r/235488 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0db83a94f6dfe9baa9696a952168ad91852c9104 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
