jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: move variable outside for loop in SavedPagesFragment
......................................................................
Hygiene: move variable outside for loop in SavedPagesFragment
This patch moves a variable which doesn't depend on the loop counter outside
of the for loop. This was recommended by BearND in the patch that implemented
this functionality.
Change-Id: I51c51140c9efe9a01c518c6060d5a4e7e7f1758e
---
M app/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Sniedzielski: Looks good to me, approved
Mholloway: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java
b/app/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java
index e49b204..d4da830 100644
--- a/app/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java
+++ b/app/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java
@@ -319,8 +319,10 @@
if (!isAdded() || ((PageActivity)getActivity()).isSearching()) {
return;
}
+
+ // Only enable and show the buttons in the options menu if there are
saved pages in the list
+ boolean enabled = savedPagesList.getCount() > 0;
for (int id : Arrays.asList(R.id.menu_clear_all_saved_pages,
R.id.menu_refresh_all_saved_pages)) {
- boolean enabled = savedPagesList.getCount() > 0;
menu.findItem(id).setEnabled(enabled).setVisible(enabled);
}
}
--
To view, visit https://gerrit.wikimedia.org/r/235409
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51c51140c9efe9a01c518c6060d5a4e7e7f1758e
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Deskana <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
