jenkins-bot has submitted this change and it was merged.
Change subject: Clean up CSS values in .oo-ui-transition calls
......................................................................
Clean up CSS values in .oo-ui-transition calls
* Consistently order as '<property> <duration> <timing-function>'.
* Fill in missing timing-values (either make default 'linear' explicit
or fill in ease-in-out where it seems intended but missing).
Change-Id: Iedf6577baa4723acbbf5ad15fbe04fe44460fdf9
---
M src/styles/layouts/MenuLayout.less
M src/themes/apex/elements.less
M src/themes/apex/widgets.less
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/styles/layouts/MenuLayout.less
b/src/styles/layouts/MenuLayout.less
index c5080e2..dec2753 100644
--- a/src/styles/layouts/MenuLayout.less
+++ b/src/styles/layouts/MenuLayout.less
@@ -10,7 +10,7 @@
&-menu,
&-content {
position: absolute;
- .oo-ui-transition(all ease-in-out 200ms);
+ .oo-ui-transition(all 200ms ease-in-out);
}
// These are overridden with 'auto' or '0' later
diff --git a/src/themes/apex/elements.less b/src/themes/apex/elements.less
index 1a12070..3866c82 100644
--- a/src/themes/apex/elements.less
+++ b/src/themes/apex/elements.less
@@ -33,7 +33,7 @@
> .oo-ui-buttonElement-button {
> .oo-ui-iconElement-icon {
/* Don't animate opacities for now, causes
wiggling in Chrome (bug 63020) */
- /*.oo-ui-transition(opacity 200ms);*/
+ /*.oo-ui-transition(opacity 200ms
ease-in-out);*/
}
&:hover,
diff --git a/src/themes/apex/widgets.less b/src/themes/apex/widgets.less
index 099d5e6..975e539 100644
--- a/src/themes/apex/widgets.less
+++ b/src/themes/apex/widgets.less
@@ -369,7 +369,7 @@
border: 1px solid #ccc;
box-shadow: 0 0 0 white, inset 0 0.1em 0.2em #ddd;
border-radius: 0.25em;
- .oo-ui-transition(border-color 200ms, box-shadow 200ms);
+ .oo-ui-transition(border-color 200ms ease-in-out, box-shadow
200ms ease-in-out);
&.oo-ui-pendingElement-pending {
background-color: transparent;
@@ -1084,7 +1084,7 @@
&-bar {
height: 1em;
border-right: 1px solid #ccc;
- .oo-ui-transition(width 200ms, margin-left 200ms);
+ .oo-ui-transition(width 200ms linear, margin-left 200ms linear);
.oo-ui-vertical-gradient(@progressive-gradient-start,
@progressive-gradient-end);
}
&-indeterminate {
--
To view, visit https://gerrit.wikimedia.org/r/235645
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iedf6577baa4723acbbf5ad15fbe04fe44460fdf9
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
