Tweichart has uploaded a new change for review.
https://gerrit.wikimedia.org/r/235688
Change subject: [RFC] dom changes for better seo
......................................................................
[RFC] dom changes for better seo
* top navigation moved (now after content)
* content actions moved (now after content)
* added css for same display as before
Change-Id: I61dbb64d4f5927a77af5a284b32f1032fc488368
---
M BlueSpiceSkin.skin.php
M resources/components/skin.contentActions.less
M resources/components/skin.menuTop.less
M resources/screen.layout.less
4 files changed, 56 insertions(+), 41 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/BlueSpiceSkin
refs/changes/88/235688/1
diff --git a/BlueSpiceSkin.skin.php b/BlueSpiceSkin.skin.php
index 4ee22d1..811e804 100644
--- a/BlueSpiceSkin.skin.php
+++ b/BlueSpiceSkin.skin.php
@@ -70,20 +70,9 @@
wfSuppressWarnings();
?>
<div id="bs-wrapper">
- <div id="bs-menu-top" class="clearfix">
- <?php $this->printLogo(); ?>
- <div id="bs-menu-top-left">
- <?php $this->printNavigationSites(); ?>
- </div>
- <div id="bs-menu-top-right">
- <?php $this->printPersonalTools(); ?>
- <?php $this->printSearchBox(); ?>
- </div>
- </div>
<div id="bs-application">
<!-- #bs-content-column START -->
<div id="bs-content-column">
- <?php $this->printContentActions(); ?>
<?php $this->printDataBeforeContent();
?>
<div id="content" class="mw-body"
role="main">
<a id="top"></a>
@@ -116,6 +105,7 @@
<?php $this->html(
'debughtml' ); ?>
</div>
</div>
+ <?php $this->printContentActions(); ?>
<?php $this->printDataAfterContent(); ?>
</div>
<!-- #bs-content-column END -->
@@ -125,35 +115,43 @@
</div>
<!-- #bs-left-column END -->
<!-- #bs-footer START -->
- <div id="footer" <?php
$this->html('userlangattributes') ?>>
- <?php
- $aFooterIcons = $this->getFooterIcons("icononly");
- $aFooterLinks = $this->getFooterLinks();
- foreach ($aFooterLinks as $sCategory => $aLinks):
- ?>
- <ul id="footer-<?php echo
$sCategory ?>">
- <?php
- foreach ($aLinks as
$sLink) {
- echo '<li
id="footer-' . $sCategory . '-' . $sLink . '">' . $this->data[$sLink] . '</li>';
- }
- ?>
- </ul>
- <?php endforeach; ?>
- <?php
- if (count($aFooterIcons) > 0):
- ?>
- <ul id="footer-icons"
class="noprint">
- <?php foreach (
$aFooterIcons as $blockName => $aFooterIconBlock ): ?>
- <li
id="footer-<?php echo htmlspecialchars($blockName); ?>ico">
- <?php
foreach ( $aFooterIconBlock as $icon ): ?>
-
<?php echo $this->getSkin()->makeFooterIcon($icon); ?>
- <?php
endforeach; ?>
- </li>
- <?php endforeach; ?>
- </ul>
- <?php endif; ?>
+ <div id="footer" <?php
$this->html('userlangattributes') ?>>
+ <?php
+ $aFooterIcons =
$this->getFooterIcons("icononly");
+ $aFooterLinks = $this->getFooterLinks();
+ foreach ($aFooterLinks as $sCategory =>
$aLinks):
+ ?>
+ <ul id="footer-<?php echo $sCategory
?>">
+ <?php
+ foreach ($aLinks as $sLink) {
+ echo '<li id="footer-'
. $sCategory . '-' . $sLink . '">' . $this->data[$sLink] . '</li>';
+ }
+ ?>
+ </ul>
+ <?php endforeach; ?>
+ <?php if (count($aFooterIcons) > 0): ?>
+ <ul id="footer-icons" class="noprint">
+ <?php foreach ( $aFooterIcons
as $blockName => $aFooterIconBlock ): ?>
+ <li id="footer-<?php echo
htmlspecialchars($blockName); ?>ico">
+ <?php foreach (
$aFooterIconBlock as $icon ): ?>
+ <?php echo
$this->getSkin()->makeFooterIcon($icon); ?>
+ <?php endforeach; ?>
+ </li>
+ <?php endforeach; ?>
+ </ul>
+ <?php endif; ?>
+ </div>
+ <!-- #bs-footer END -->
+ </div>
+ <div id="bs-menu-top" class="clearfix">
+ <?php $this->printLogo(); ?>
+ <div id="bs-menu-top-left">
+ <?php $this->printNavigationSites(); ?>
</div>
- <!-- #bs-footer END -->
+ <div id="bs-menu-top-right">
+ <?php $this->printPersonalTools(); ?>
+ <?php $this->printSearchBox(); ?>
+ </div>
</div>
<?php $this->printSkyScraper(); ?>
</div>
diff --git a/resources/components/skin.contentActions.less
b/resources/components/skin.contentActions.less
index 4e5eb1d..045301f 100644
--- a/resources/components/skin.contentActions.less
+++ b/resources/components/skin.contentActions.less
@@ -7,6 +7,8 @@
#left-navigation,
#right-navigation {
+ position: absolute;
+ top: 0;
min-height: 30px;
> div {
float: left;
@@ -80,8 +82,11 @@
}
}
+#left-navigation {
+ left: 0;
+}
#right-navigation {
- float: right;
+ right: 0;
}
#bs-data-before-content,
diff --git a/resources/components/skin.menuTop.less
b/resources/components/skin.menuTop.less
index f1b63c9..0de76f5 100644
--- a/resources/components/skin.menuTop.less
+++ b/resources/components/skin.menuTop.less
@@ -60,6 +60,13 @@
width: auto;
}
+#bs-menu-top{
+ margin-top: 0px;
+ height: 129px;
+ float: none;
+ position: absolute;
+ top: 0;
+}
#bs-button-user ul#bs-personal-menu, #bs-cactions-button ul.bs-personal-menu{
position: absolute;
diff --git a/resources/screen.layout.less b/resources/screen.layout.less
index 2032029..309416f 100644
--- a/resources/screen.layout.less
+++ b/resources/screen.layout.less
@@ -37,13 +37,18 @@
float:left;
clear:none;
padding:0;
- margin-top: 25px;
+ margin-top: 125px;
}
#bs-content-column, #footer {
margin-left: @bs-margin-left-content;
}
+#bs-content-column{
+ position: relative;
+ padding-top: 30px;
+}
+
#footer {
overflow:hidden;
border-top:1px solid #989898;
--
To view, visit https://gerrit.wikimedia.org/r/235688
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61dbb64d4f5927a77af5a284b32f1032fc488368
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/BlueSpiceSkin
Gerrit-Branch: master
Gerrit-Owner: Tweichart <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
