Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/235692
Change subject: Convert timing metrics to milliseconds ...................................................................... Convert timing metrics to milliseconds Timing metrics which are sent to statsd must be in milliseconds[1]. [1] http://statsd.readthedocs.org/en/latest/types.html#timers Change-Id: Iaaa40b88aa670aaef41c4dab0231c6cb8f5498bc --- M nodepool/nodepool.py M nodepool/task_manager.py 2 files changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/debs/nodepool refs/changes/92/235692/1 diff --git a/nodepool/nodepool.py b/nodepool/nodepool.py index 21f4c4e..d0a20ff 100644 --- a/nodepool/nodepool.py +++ b/nodepool/nodepool.py @@ -127,8 +127,7 @@ if statsd and self.result == 'SUCCESS': start = node.state_time - end = time.time() - dt = end - start + dt = int((time.time() - start) * 1000) # nodepool.job.tempest key = 'nodepool.job.%s' % self.jobname diff --git a/nodepool/task_manager.py b/nodepool/task_manager.py index 487e28a..48108d7 100644 --- a/nodepool/task_manager.py +++ b/nodepool/task_manager.py @@ -103,7 +103,7 @@ #nodepool.task.PROVIDER.subkey subkey = type(task).__name__ key = 'nodepool.task.%s.%s' % (self.name, subkey) - statsd.timing(key, dt) + statsd.timing(key, int(dt * 1000)) statsd.incr(key) self.queue.task_done() -- To view, visit https://gerrit.wikimedia.org/r/235692 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaaa40b88aa670aaef41c4dab0231c6cb8f5498bc Gerrit-PatchSet: 1 Gerrit-Project: operations/debs/nodepool Gerrit-Branch: patch-queue/debian Gerrit-Owner: Hashar <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
