Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/235767
Change subject: VisualEditorDataModule: remove $msgKeys
......................................................................
VisualEditorDataModule: remove $msgKeys
This is apparently no longer used.
Change-Id: Iccf6e00a4e96aece9a81f1f7f91024faf15b0798
---
M VisualEditorDataModule.php
1 file changed, 0 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/67/235767/1
diff --git a/VisualEditorDataModule.php b/VisualEditorDataModule.php
index 8c6badb..a0c5aeb 100644
--- a/VisualEditorDataModule.php
+++ b/VisualEditorDataModule.php
@@ -67,8 +67,6 @@
}
protected function getMessageInfo() {
- $msgKeys = array();
-
// Messages that just require simple parsing
$msgArgs = array(
'minoredit' => array( 'minoredit' ),
@@ -101,23 +99,13 @@
$title = Title::newFromText( 'Dwimmerlaik' );
Hooks::run( 'EditPageCopyrightWarning', array( $title,
&$copywarnMsg ) );
- // Keys used in copyright warning
- $msgKeys[] = 'copyrightpage';
- $msgKeys[] = $copywarnMsg[0];
// Normalise to 'copyrightwarning' so we have a consistent key
in the front-end.
$msgArgs[ 'copyrightwarning' ] = $copywarnMsg;
// Citation tools
$msgVals['visualeditor-cite-tool-definition.json'] =
json_encode( self::getCitationTools() );
- $msgKeys = array_values( array_unique( array_merge(
- $msgKeys,
- array_keys( $msgArgs ),
- array_keys( $msgVals )
- ) ) );
-
return array(
- 'keys' => $msgKeys,
'args' => $msgArgs,
'vals' => $msgVals,
);
@@ -140,7 +128,6 @@
if ( !isset( $tool->title ) ) {
$tool->title =
wfMessage(
'visualeditor-cite-tool-name-' . $tool->name )->text();
- $msgKeys[] = $tool->title;
}
$citationTools[] = $tool;
}
--
To view, visit https://gerrit.wikimedia.org/r/235767
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iccf6e00a4e96aece9a81f1f7f91024faf15b0798
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
