[MediaWiki-commits] [Gerrit] Declare functions before use in ve.demo.init.js - change (VisualEditor/VisualEditor)

[Divec (Code Review)]

Divec has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/235895

Change subject: Declare functions before use in ve.demo.init.js
......................................................................

Declare functions before use in ve.demo.init.js

Fixes an error newly detected by upgraded jshint (version 2.9.0)

Change-Id: Ibc015fc05577d258fcfffb021e766c5dec01e48c
---
M demos/ve/ve.demo.init.js
1 file changed, 10 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/95/235895/1

diff --git a/demos/ve/ve.demo.init.js b/demos/ve/ve.demo.init.js
index ba12d55..ffa0cf4 100644
--- a/demos/ve/ve.demo.init.js
+++ b/demos/ve/ve.demo.init.js
@@ -6,7 +6,8 @@
 
 new ve.init.sa.Platform( ve.messagePaths ).initialize().done( function () {
 
-       var $toolbar = $( '.ve-demo-targetToolbar' ),
+       var updateStylesFromDir, updateHash, addSurfaceContainer, 
createSurfacesFromHash,
+               $toolbar = $( '.ve-demo-targetToolbar' ),
                $editor = $( '.ve-demo-editor' ),
                target = new ve.demo.target(),
 
@@ -35,7 +36,7 @@
                        new OO.ui.ButtonOptionWidget( { data: 'mobile', label: 
'Mobile' } )
                ] );
 
-       function updateStylesFromDir() {
+       updateStylesFromDir = function updateStylesFromDir() {
                var oldDir = currentDir === 'ltr' ? 'rtl' : 'ltr';
 
                $( '.stylesheet-' + currentDir ).prop( 'disabled', false );
@@ -44,7 +45,7 @@
                $( 'body' ).css( 'direction', currentDir )
                        .addClass( 've-demo-dir-' + currentDir )
                        .removeClass( 've-demo-dir-' + oldDir );
-       }
+       };
 
        // Initialization
 
@@ -112,7 +113,7 @@
 
        $editor.append( target.$element );
 
-       function updateHash() {
+       updateHash = function updateHash() {
                var i, pages = [];
                if ( history.replaceState ) {
                        for ( i = 0; i < ve.demo.surfaceContainers.length; i++ 
) {
@@ -120,9 +121,9 @@
                        }
                        history.replaceState( null, document.title, '#!' + 
pages.join( ',' ) );
                }
-       }
+       };
 
-       function addSurfaceContainer( page ) {
+       addSurfaceContainer = function addSurfaceContainer( page ) {
                var surfaceContainer;
 
                if ( !page && ve.demo.surfaceContainers.length ) {
@@ -133,9 +134,9 @@
                surfaceContainer.on( 'changePage', updateHash );
                updateHash();
                target.$element.append( surfaceContainer.$element );
-       }
+       };
 
-       function createSurfacesFromHash( hash ) {
+       createSurfacesFromHash = function createSurfacesFromHash( hash ) {
                var i, pages = [];
                if ( /^#!pages\/.+$/.test( hash ) ) {
                        pages = hash.slice( 2 ).split( ',' );
@@ -147,7 +148,7 @@
                } else {
                        addSurfaceContainer( 'pages/simple.html' );
                }
-       }
+       };
 
        createSurfacesFromHash( location.hash );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/235895
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc015fc05577d258fcfffb021e766c5dec01e48c
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Divec <da...@troi.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits