Daniel Kinzler has submitted this change and it was merged. Change subject: Fix check to see if element is there already. ......................................................................
Fix check to see if element is there already. PHP docs disagree with reality when it comes to return type of offsetGet, so switching to offsetExists. Issue spotted by Brad Jorsch Change-Id: I4ce1651d4ed681ab55cf297090ee963b64584bbf --- M includes/site/SiteArray.php 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Daniel Kinzler: Verified; Looks good to me, approved jenkins-bot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37637 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ce1651d4ed681ab55cf297090ee963b64584bbf Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: Reedy <re...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
