Ricordisamoa has uploaded a new change for review.
https://gerrit.wikimedia.org/r/235996
Change subject: LinkBeginHookHandler: compare target with link text Title-wise
......................................................................
LinkBeginHookHandler: compare target with link text Title-wise
Bug: T104825
Change-Id: I95214bc324f7a51e92fe4b67fb07707d3670b022
---
M repo/includes/Hooks/LinkBeginHookHandler.php
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/96/235996/1
diff --git a/repo/includes/Hooks/LinkBeginHookHandler.php
b/repo/includes/Hooks/LinkBeginHookHandler.php
index 08f524d..ba3a316 100644
--- a/repo/includes/Hooks/LinkBeginHookHandler.php
+++ b/repo/includes/Hooks/LinkBeginHookHandler.php
@@ -163,7 +163,10 @@
// if custom link text is given, there is no point in
overwriting it
// but not if it is similar to the plain title
if ( $html !== null && $target->getFullText() !== $html ) {
- return;
+ $titleFromHtml = Title::newFromText( $html );
+ if ( !is_object( $titleFromHtml ) ||
!$titleFromHtml->equals( $target ) ) {
+ return;
+ }
}
$entityId = $this->entityIdLookup->getEntityIdForTitle( $target
);
--
To view, visit https://gerrit.wikimedia.org/r/235996
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95214bc324f7a51e92fe4b67fb07707d3670b022
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
