Ori.livneh has submitted this change and it was merged.
Change subject: GeoIP: specify lat/lon to two decimal places
......................................................................
GeoIP: specify lat/lon to two decimal places
* Change the format specifier for lat / lon coords in the GeoIP
cookie to %.2f instead of %.4f, which is overly specific.
* Update the comment to reflect the current format of the cookie.
Change-Id: If16a7cbda4636af792101394f636b896c2b6e7f8
---
M templates/varnish/geoip.inc.vcl.erb
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Krinkle: Looks good to me, but someone else must approve
Ori.livneh: Verified; Looks good to me, approved
BBlack: Looks good to me, but someone else must approve
diff --git a/templates/varnish/geoip.inc.vcl.erb
b/templates/varnish/geoip.inc.vcl.erb
index 5314e09..5274d22 100644
--- a/templates/varnish/geoip.inc.vcl.erb
+++ b/templates/varnish/geoip.inc.vcl.erb
@@ -207,8 +207,8 @@
int snp_len;
if (record) {
- // Set-Cookie:
GeoIP=US:San_Francisco:37.7749:-122.4194:v4; path=/
- snp_len = snprintf(cookie_buf, sizeof(cookie_buf),
"GeoIP=%s:%s:%s:%.4f:%.4f:%s",
+ // Set-Cookie:
GeoIP=US:CA:San_Francisco:37.77:-122.41:v4; path=/
+ snp_len = snprintf(cookie_buf, sizeof(cookie_buf),
"GeoIP=%s:%s:%s:%.2f:%.2f:%s",
record->country_code ? record->country_code :
"",
record->region ? record->region : "",
record->city ? record->city : "",
--
To view, visit https://gerrit.wikimedia.org/r/235543
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If16a7cbda4636af792101394f636b896c2b6e7f8
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: BBlack <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
