Paladox has uploaded a new change for review.
https://gerrit.wikimedia.org/r/236067
Change subject: Add jshint in npm
......................................................................
Add jshint in npm
Use jshint in npm instead of having seprate test. This allows for using
newer versions of jshint.
Change-Id: I85859df9f5f97a4bb42716262ad32616c28fe8a9
---
M Gruntfile.js
M package.json
2 files changed, 14 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Josa
refs/changes/67/236067/1
diff --git a/Gruntfile.js b/Gruntfile.js
index 5a87e7b..ffc5972 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -1,10 +1,19 @@
/*jshint node:true */
module.exports = function ( grunt ) {
+ var conf = grunt.file.readJSON( 'extension.json' );
+
grunt.loadNpmTasks( 'grunt-banana-checker' );
grunt.loadNpmTasks( 'grunt-jsonlint' );
- var conf = grunt.file.readJSON( 'extension.json' );
grunt.initConfig( {
+ jshint: {
+ all: [
+ '*.js'
+ ]
+ },
+ jscs: {
+ src: '<%= jshint.all %>'
+ },
banana: conf.MessagesDirs,
jsonlint: {
all: [
@@ -14,6 +23,6 @@
}
} );
- grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] );
+ grunt.registerTask( 'test', [ 'jshint', 'jscs', 'jsonlint', 'banana' ]
);
grunt.registerTask( 'default', 'test' );
};
diff --git a/package.json b/package.json
index 76e8a82..97ab022 100644
--- a/package.json
+++ b/package.json
@@ -7,6 +7,8 @@
"grunt": "0.4.5",
"grunt-cli": "0.1.13",
"grunt-banana-checker": "0.2.2",
- "grunt-jsonlint": "1.0.4"
+ "grunt-jsonlint": "1.0.4",
+ "grunt-contrib-jshint": "0.11.3",
+ "grunt-jscs": "2.1.0"
}
}
--
To view, visit https://gerrit.wikimedia.org/r/236067
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85859df9f5f97a4bb42716262ad32616c28fe8a9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Josa
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
