Ejegg has uploaded a new change for review.
https://gerrit.wikimedia.org/r/236069
Change subject: Add version to banner history log entries in KV store
......................................................................
Add version to banner history log entries in KV store
Space-saving variations include naming the enty key 'v' (depending
on serialization), or making the log an object with properties
'version' and 'entries'. #2 would necessitate migrating old entries
on format change.
Change-Id: Id6179a9c921dec54718c59b65e93f93916e43da6
---
M resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/69/236069/1
diff --git a/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
b/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
index 868a19b..e844287 100644
--- a/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
+++ b/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
@@ -14,6 +14,7 @@
readyToLogPromise,
BANNER_HISTORY_KV_STORE_KEY = 'banner_history',
+ BANNER_HISTORY_LOG_ENTRY_VERSION = 1, // Update when log format
changes
EVENT_LOGGING_SCHEMA = 'CentralNoticeBannerHistory',
// The maximum random shift applied to timestamps, for user
privacy
@@ -52,6 +53,7 @@
time = now + randomTimeShift,
logEntry = {
+ version: BANNER_HISTORY_LOG_ENTRY_VERSION,
language: data.uselang,
country: data.country,
isAnon: data.anonymous,
--
To view, visit https://gerrit.wikimedia.org/r/236069
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6179a9c921dec54718c59b65e93f93916e43da6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
