OliverKeyes has submitted this change and it was merged.
Change subject: Patch to address comments + simplify HTTP status stuff.
......................................................................
Patch to address comments + simplify HTTP status stuff.
Change-Id: I8e8725350bcda389d02b3f12f5e89223d4b99dc2
---
M wdqs/basic_usage.R
1 file changed, 7 insertions(+), 8 deletions(-)
Approvals:
OliverKeyes: Verified; Looks good to me, approved
diff --git a/wdqs/basic_usage.R b/wdqs/basic_usage.R
index 9cd975e..5dc37e6 100644
--- a/wdqs/basic_usage.R
+++ b/wdqs/basic_usage.R
@@ -23,7 +23,7 @@
# Write query and dump to file
query <- paste0("USE wmf;
SELECT year, month, day, uri_path,
- (floor(cast(http_status as int) / 100) * 100) AS
http_category,
+ UPPER(http_status IN('200','304')) as success,
COUNT(*) AS n
FROM webrequest",
subquery,
@@ -31,7 +31,7 @@
AND uri_host = 'query.wikidata.org'
AND uri_path IN('/', '/bigdata/namespace/wdq/sparql')
GROUP BY year, month, day, uri_path,
- floor(cast(http_status as int) / 100) * 100;")
+ UPPER(http_status IN('200','304'));")
query_dump <- tempfile()
cat(query, file = query_dump)
@@ -53,11 +53,10 @@
}
-# Backlog (start date: 2015-07-28):
-backlog <- function(days) {
- for (i in days:1) try(main(Sys.Date() - i), silent = TRUE)
-}; backlog(30) # as of 2015-08-27In the
+# backlog <- function(days) {
+# for (i in days:1) try(main(Sys.Date() - i), silent = TRUE)
+# }; backlog(30)
# Run and kill
-# main()
-# q(save = "no")
+main()
+q(save = "no")
--
To view, visit https://gerrit.wikimedia.org/r/236065
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e8725350bcda389d02b3f12f5e89223d4b99dc2
Gerrit-PatchSet: 4
Gerrit-Project: wikimedia/discovery/golden
Gerrit-Branch: master
Gerrit-Owner: Bearloga <[email protected]>
Gerrit-Reviewer: OliverKeyes <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
