jenkins-bot has submitted this change and it was merged.
Change subject: Suppress link previews for non-mainspace links
......................................................................
Suppress link previews for non-mainspace links
Currently, link previews are shown for non-mainspace pages (including
File, Wikipedia, and Portal), which isn't the behavior we want. This
patch adds a check for null namespace (i.e., mainspace) before showing
a link preview.
Bug: T108377
Change-Id: Ic6f29c2f25762d004f32bcbd8cc9142b1f3cd0fc
---
M app/src/main/java/org/wikipedia/page/PageFragment.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Sniedzielski: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/page/PageFragment.java
b/app/src/main/java/org/wikipedia/page/PageFragment.java
index dcdaf62..a643e44 100755
--- a/app/src/main/java/org/wikipedia/page/PageFragment.java
+++ b/app/src/main/java/org/wikipedia/page/PageFragment.java
@@ -57,6 +57,7 @@
import android.support.v7.app.AppCompatActivity;
import android.support.v7.view.ActionMode;
import android.text.Html;
+import android.text.TextUtils;
import android.util.Log;
import android.util.TypedValue;
import android.view.Gravity;
@@ -400,7 +401,7 @@
if (referenceDialog != null && referenceDialog.isShowing()) {
referenceDialog.dismiss();
}
- if (!app.isProdRelease() && app.getLinkPreviewVersion() == 0) {
+ if (!TextUtils.isEmpty(title.getNamespace()) || (!app.isProdRelease()
&& app.getLinkPreviewVersion() == 0)) {
HistoryEntry historyEntry = new HistoryEntry(title,
HistoryEntry.SOURCE_INTERNAL_LINK);
getPageActivity().displayNewPage(title, historyEntry);
new LinkPreviewFunnel(app).logNavigate();
--
To view, visit https://gerrit.wikimedia.org/r/235281
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6f29c2f25762d004f32bcbd8cc9142b1f3cd0fc
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
