Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/236533
Change subject: Replace MediaWikiSite with Site in SiteLinksViewTest
......................................................................
Replace MediaWikiSite with Site in SiteLinksViewTest
An other test that obviously (otherwise it would fail) does not need
the specialized class.
Nice side effect is that this get's rid of a deprecation warning on
the newFromGlobalId calls.
Change-Id: I6743367328c19bc268ea620892e47b2fd4689c08
---
M view/tests/phpunit/SiteLinksViewTest.php
1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/33/236533/1
diff --git a/view/tests/phpunit/SiteLinksViewTest.php
b/view/tests/phpunit/SiteLinksViewTest.php
index eddfad9..1442881 100644
--- a/view/tests/phpunit/SiteLinksViewTest.php
+++ b/view/tests/phpunit/SiteLinksViewTest.php
@@ -2,8 +2,8 @@
namespace Wikibase\Test;
-use MediaWikiSite;
use MediaWikiTestCase;
+use Site;
use SiteList;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Entity\Item;
@@ -195,13 +195,16 @@
* @return SiteList
*/
private function newSiteList() {
- $dummySite = MediaWikiSite::newFromGlobalId( 'enwiki' );
+ $dummySite = new Site();
+ $dummySite->setGlobalId( 'enwiki' );
$dummySite->setGroup( 'wikipedia' );
- $dummySite2 = MediaWikiSite::newFromGlobalId( 'specialwiki' );
+ $dummySite2 = new Site();
+ $dummySite2->setGlobalId( 'specialwiki' );
$dummySite2->setGroup( 'special group' );
- $dummySite3 = MediaWikiSite::newFromGlobalId( 'dewiki' );
+ $dummySite3 = new Site();
+ $dummySite3->setGlobalId( 'dewiki' );
$dummySite3->setGroup( 'wikipedia' );
return new SiteList( array( $dummySite, $dummySite2,
$dummySite3 ) );
--
To view, visit https://gerrit.wikimedia.org/r/236533
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6743367328c19bc268ea620892e47b2fd4689c08
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
