jenkins-bot has submitted this change and it was merged.
Change subject: ParserOptions: added comment regarding editsections usage.
......................................................................
ParserOptions: added comment regarding editsections usage.
// @note: as of Feb 2015, core never sets the editsection flag, since it uses
// <mw:editsection> tags to inject editsections on the fly. However, extensions
// may be using it by calling ParserOption::optionUsed resp.
ParserOutput::registerOption
// directly. At least Wikibase does at this point in time.
Change-Id: Ief95ecb3ae1f5699b788dd3dad0eaf1aa6cc163c
---
M includes/parser/ParserOptions.php
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
Addshore: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/parser/ParserOptions.php
b/includes/parser/ParserOptions.php
index 4459047..1073aed 100644
--- a/includes/parser/ParserOptions.php
+++ b/includes/parser/ParserOptions.php
@@ -802,6 +802,10 @@
$confstr .= $wgRenderHashAppend;
+ // @note: as of Feb 2015, core never sets the editsection flag,
since it uses
+ // <mw:editsection> tags to inject editsections on the fly.
However, extensions
+ // may be using it by calling ParserOption::optionUsed resp.
ParserOutput::registerOption
+ // directly. At least Wikibase does at this point in time.
if ( !in_array( 'editsection', $forOptions ) ) {
$confstr .= '!*';
} elseif ( !$this->mEditSection ) {
--
To view, visit https://gerrit.wikimedia.org/r/193266
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief95ecb3ae1f5699b788dd3dad0eaf1aa6cc163c
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Platonides <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
