jenkins-bot has submitted this change and it was merged.
Change subject: mw.trackSubscriber: Log platform as phone vs. desktop
......................................................................
mw.trackSubscriber: Log platform as phone vs. desktop
Change-Id: I71c25f28098c72ed779117da9c243dc3a87e611d
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
M modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
M modules/ve-mw/init/ve.init.mw.Target.js
M modules/ve-mw/init/ve.init.mw.trackSubscriber.js
4 files changed, 16 insertions(+), 1 deletion(-)
Approvals:
Alex Monk: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
index 3ec9f60..05e206f 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
@@ -115,6 +115,8 @@
}
};
+ve.init.mw.DesktopArticleTarget.static.platformType = 'desktop';
+
/* Events */
/**
diff --git a/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
index 0675fb7..103de84 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
@@ -72,6 +72,9 @@
ve.init.mw.MobileArticleTarget.static.name = 'mobile';
+// FIXME Some of these users will be on tablets, check for this
+ve.init.mw.MobileArticleTarget.static.platformType = 'phone';
+
/* Methods */
/**
diff --git a/modules/ve-mw/init/ve.init.mw.Target.js
b/modules/ve-mw/init/ve.init.mw.Target.js
index ae0d760..f9e0ed6 100644
--- a/modules/ve-mw/init/ve.init.mw.Target.js
+++ b/modules/ve-mw/init/ve.init.mw.Target.js
@@ -245,12 +245,22 @@
/**
* Type of integration. Used by ve.init.mw.trackSubscriber.js for event
tracking.
+ *
* @static
* @property {string}
* @inheritable
*/
ve.init.mw.Target.static.integrationType = 'page';
+/**
+ * Type of platform. Used by ve.init.mw.trackSubscriber.js for event tracking.
+ *
+ * @static
+ * @property {string}
+ * @inheritable
+ */
+ve.init.mw.Target.static.platformType = 'other';
+
/* Static Methods */
/**
diff --git a/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
b/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
index c815a1e..958a708 100644
--- a/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
+++ b/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
@@ -98,7 +98,7 @@
version: 1,
action: action,
editor: 'visualeditor',
- platform: 'desktop', // FIXME
+ platform: ve.init && ve.init.target &&
ve.init.target.constructor.static.platformType || 'other',
integration: ve.init && ve.init.target &&
ve.init.target.constructor.static.integrationType || 'page',
'page.id': mw.config.get( 'wgArticleId' ),
'page.title': mw.config.get( 'wgPageName' ),
--
To view, visit https://gerrit.wikimedia.org/r/235661
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71c25f28098c72ed779117da9c243dc3a87e611d
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
