Sumit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/236735
Change subject: WikidataPageBanner set focus after banner load
......................................................................
WikidataPageBanner set focus after banner load
Trigger positionBanner() after banner image has loaded. Also reset margin in
positionBanner() before setting new focus values, so that focus is not affected
by previously set margins.
Bug: T111710
Change-Id: I21fbf96b5c558afd19a2374d7eb942020860fc0a
---
M
resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
1 file changed, 7 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/35/236735/1
diff --git
a/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
b/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
index d5b8692..4354935 100644
---
a/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
+++
b/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
@@ -18,7 +18,9 @@
transform: 'translate(0)',
MozTransform: 'translate(0)',
WebkitTransform: 'translate(0)',
- msTransform: 'translate(0)'
+ msTransform: 'translate(0)',
+ 'margin-left': 0,
+ 'margin-top': 0
} );
// Adjust vertical focus
if ( $wpbBannerImage.height() > $container.height() ) {
@@ -66,7 +68,10 @@
positionBanner( $wpbBannerImageContainer );
}
) );
- positionBanner( $wpbBannerImageContainer );
+ // set focus after image has loaded
+ $( 'img.wpb-banner-image' ).load( function() {
+ positionBanner( $wpbBannerImageContainer );
+ } );
// Expose interface for testing.
mw.wpb = {
positionBanner: positionBanner
--
To view, visit https://gerrit.wikimedia.org/r/236735
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I21fbf96b5c558afd19a2374d7eb942020860fc0a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
