Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/237424
Change subject: Only use inverted icons for skins using the MediaWiki OOUI theme
......................................................................
Only use inverted icons for skins using the MediaWiki OOUI theme
Otherwise it causes flashes due to colors changing in skins that don't
use it, like MonoBook
Bug: T111821
Change-Id: I03acdbcbfa3912b439a18187d52944931e94506a
---
M Hooks.php
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/24/237424/1
diff --git a/Hooks.php b/Hooks.php
index 956caf0..123f6f6 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -651,8 +651,13 @@
$url = SpecialPage::getTitleFor( 'Notifications'
)->getLocalURL();
- $msgLinkClasses = array( 'mw-echo-notifications-badge
oo-ui-image-invert oo-ui-iconElement oo-ui-iconElement-icon
oo-ui-icon-speechBubble' );
- $alertLinkClasses = array( 'mw-echo-notifications-badge
oo-ui-image-invert oo-ui-iconElement oo-ui-iconElement-icon' );
+ // HACK: inverted icons only work in the "MediaWiki" OOUI theme
+ // Avoid flashes in skins that don't use it (T111821)
+ $useInverted = get_class( OOUI\Theme::singleton() ) ===
'OOUI\\MediaWikiTheme';
+ $oouiImageClass = 'oo-ui-image' . ( $useInverted ? '-invert' :
'' );
+
+ $msgLinkClasses = array( "mw-echo-notifications-badge
$oouiImageClass oo-ui-iconElement oo-ui-iconElement-icon
oo-ui-icon-speechBubble" );
+ $alertLinkClasses = array( "mw-echo-notifications-badge
$oouiImageClass oo-ui-iconElement oo-ui-iconElement-icon" );
if (
$msgCount != 0 && // no unread notifications
--
To view, visit https://gerrit.wikimedia.org/r/237424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03acdbcbfa3912b439a18187d52944931e94506a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
