Hashar has uploaded a new change for review.
https://gerrit.wikimedia.org/r/237488
Change subject: Fix linting issues
......................................................................
Fix linting issues
./adminlogbot.py:
275:25: E123 closing bracket does not match indentation
of opening bracket's line
313:8: E713 test for membership should be 'not in'
337:16: E713 test for membership should be 'not in'
Ignoring E128 continuation line under-indented for visual indent
Change-Id: I86e088570493fb82eb0ec226060828e976b7453e
---
M adminlogbot.py
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/debs/adminbot
refs/changes/88/237488/1
diff --git a/adminlogbot.py b/adminlogbot.py
index 584b95e..8d7d004 100755
--- a/adminlogbot.py
+++ b/adminlogbot.py
@@ -269,7 +269,8 @@
else:
title = "Master"
try:
- self.connection.privmsg(event.target(),
+ self.connection.privmsg(
+ event.target(),
"Logged the message at {url}, {author}".format(
url=pageurl, author=title
)
@@ -310,7 +311,7 @@
conf = imp.load_source(module, confdir + "/" + fname)
# discard if this isn't actually a bot config file
- if not 'targets' in conf.__dict__:
+ if 'targets' not in conf.__dict__:
logging.error("%s does not appear to be a valid bot config." %
args.confarg)
exit(1)
@@ -334,7 +335,7 @@
conf = imp.load_source(module, confdir + "/" + fname)
# discard if this isn't actually a bot config file
- if not 'targets' in conf.__dict__:
+ if 'targets' not in conf.__dict__:
continue
bots.append(logbot(module, conf))
--
To view, visit https://gerrit.wikimedia.org/r/237488
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I86e088570493fb82eb0ec226060828e976b7453e
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/adminbot
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
