Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/237598
Change subject: Fixed Style/HashSyntax RuboCop offense
......................................................................
Fixed Style/HashSyntax RuboCop offense
Bug: T112099
Change-Id: Iadfa960738722a70b2c40fed28125fc4b7728c68
---
M .rubocop_todo.yml
M tests/browser/features/step_definitions/common_steps.rb
2 files changed, 2 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather
refs/changes/98/237598/1
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 124f9da..b20ef8d 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -17,9 +17,3 @@
Style/AlignParameters:
Exclude:
- 'tests/browser/features/support/pages/gather_page.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles,
UseHashRocketsWithSymbolValues.
-Style/HashSyntax:
- Enabled: false
diff --git a/tests/browser/features/step_definitions/common_steps.rb
b/tests/browser/features/step_definitions/common_steps.rb
index e0acbf3..b0768d1 100644
--- a/tests/browser/features/step_definitions/common_steps.rb
+++ b/tests/browser/features/step_definitions/common_steps.rb
@@ -12,7 +12,7 @@
Given(/^I view one of my public collections$/) do
# create a collection with a random name
response = make_collection(@random_string)
- visit(GatherUserCollectionPage, using_params: { :id => response.data['id'] })
+ visit(GatherUserCollectionPage, using_params: { id: response.data['id'] })
end
Given(/^I am logged into the mobile website$/) do
@@ -49,7 +49,7 @@
# Ensure we do not cause a redirect
article = article.sub(/ /, '_')
# article parameters need to be encoded.
- visit(ArticlePage, using_params: { :article_name => article })
+ visit(ArticlePage, using_params: { article_name: article })
end
When(/^I click the watchstar$/) do
--
To view, visit https://gerrit.wikimedia.org/r/237598
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iadfa960738722a70b2c40fed28125fc4b7728c68
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
