jenkins-bot has submitted this change and it was merged.
Change subject: Reduce distance between notification badges
......................................................................
Reduce distance between notification badges
Notification badges are conceptually closer together than the rest of toolbar
elements.
So it makes sense to move them closer visually too.
This is just a small CSS adjustment to compensate for the default margin
that items in the menu get. If there is a cleanner way to achieve the same,
feel free to refactor.
Bug: T108190
Change-Id: I06403f67c24f045c125c505dca2101f9eed79594
(cherry picked from commit b6712be9a3948b7a7922641d9f2cf5363b8511de)
---
M modules/echo.variables.less
M modules/nojs/mw.echo.badge.less
M modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
3 files changed, 7 insertions(+), 0 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/echo.variables.less b/modules/echo.variables.less
index 1c95c55..9393006 100644
--- a/modules/echo.variables.less
+++ b/modules/echo.variables.less
@@ -1,6 +1,7 @@
@badge-padding: 0.12em;
@badge-icon-size: 1.1em;
@badge-text-color-idle: white;
+@badge-distance-adjustment: -0.4em;
@badge-background-unseen-alert: #D11813;
@badge-background-unseen-message: #5D95FF;
diff --git a/modules/nojs/mw.echo.badge.less b/modules/nojs/mw.echo.badge.less
index 3970c84..f074d52 100644
--- a/modules/nojs/mw.echo.badge.less
+++ b/modules/nojs/mw.echo.badge.less
@@ -30,6 +30,11 @@
}
}
+ #pt-notifications-message & {
+ margin-left: @badge-distance-adjustment;
+ }
+
+
&.mw-echo-unseen-notifications {
#pt-notifications-alert & {
background-color: @badge-background-unseen-alert;
diff --git a/modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
b/modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
index ae628c6..ad214e1 100644
--- a/modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
+++ b/modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
@@ -9,6 +9,7 @@
}
}
&-message {
+ margin-left: @badge-distance-adjustment;
// Must be strong to override OOUI's button background color
definition
&.oo-ui-flaggedElement-unseen > .oo-ui-buttonElement-button {
background-color: @badge-background-unseen-message;
--
To view, visit https://gerrit.wikimedia.org/r/237669
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06403f67c24f045c125c505dca2101f9eed79594
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: wmf/1.26wmf22
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Pginer <pgi...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
