Cicalese has uploaded a new change for review.
https://gerrit.wikimedia.org/r/237967
Change subject: possible values for Cargo fields should not include null values
......................................................................
possible values for Cargo fields should not include null values
Change-Id: I638468a28c20cd3345918f6fe8a4a1bda2ffcad7
---
M includes/SF_FormPrinter.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms
refs/changes/67/237967/1
diff --git a/includes/SF_FormPrinter.php b/includes/SF_FormPrinter.php
index 5137587..fe1eb1e 100644
--- a/includes/SF_FormPrinter.php
+++ b/includes/SF_FormPrinter.php
@@ -1096,7 +1096,7 @@
// values if a field and table have
// been specified.
if ( is_null( $possible_values ) &&
defined( 'CARGO_VERSION' ) && $cargo_table != null && $cargo_field != null ) {
- $possible_values =
SFUtils::getAllValuesForCargoField( $cargo_table, $cargo_field );
+ $possible_values =
SFUtils::getValuesForCargoField( $cargo_table, $cargo_field, $cargo_field . "
IS NOT NULL" );
}
if ( !is_null( $possible_values ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/237967
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I638468a28c20cd3345918f6fe8a4a1bda2ffcad7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Cicalese <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits