[MediaWiki-commits] [Gerrit] Suggestions: Make the whole suggestion item clickable - change (mediawiki...ContentTranslation)

[Santhosh (Code Review)]

Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/238107

Change subject: Suggestions: Make the whole suggestion item clickable
......................................................................

Suggestions: Make the whole suggestion item clickable

Bug: T106405
Change-Id: I63bd26febe92b529e57b6987b6b6d2262b447dfb
---
M modules/dashboard/ext.cx.suggestionlist.js
M modules/dashboard/styles/ext.cx.lists.common.less
M modules/dashboard/styles/ext.cx.translationlist.less
3 files changed, 8 insertions(+), 5 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/07/238107/1

diff --git a/modules/dashboard/ext.cx.suggestionlist.js 
b/modules/dashboard/ext.cx.suggestionlist.js
index df69afb..c046a25 100644
--- a/modules/dashboard/ext.cx.suggestionlist.js
+++ b/modules/dashboard/ext.cx.suggestionlist.js
@@ -194,6 +194,11 @@
                                target: '_blank',
                                title: mw.msg( 
'cx-suggestionlist-view-source-page' )
                        } )
+                       .click( function ( e ) {
+                               // Do not propagate to the parent suggestion 
item. Prevent opening
+                               // source selector.
+                               e.stopPropagation();
+                       } )
                        .addClass( 'cx-slitem__languages__language 
cx-slitem__languages__language--source' )
                        .text( $.uls.data.getAutonym( suggestion.sourceLanguage 
) );
 
@@ -286,14 +291,14 @@
         * Event handlers
         */
        CXSuggestionList.prototype.listen = function () {
-               this.$container.on( 'click', '.cx-suggestionlist 
.cx-slitem__translation-link', function () {
+               this.$container.on( 'click', '.cx-suggestionlist .cx-slitem', 
function () {
                        var cxSelector, suggestion;
 
                        cxSelector = $( this ).data( 'cxsourceselector' );
                        if ( cxSelector ) {
                                cxSelector.prefill();
                        } else {
-                               suggestion = $( this ).data( 'suggestion' );
+                               suggestion = $( this ).find( 
'.cx-slitem__translation-link' ).data( 'suggestion' );
                                $( this ).cxSourceSelector( {
                                        sourceLanguage: 
suggestion.sourceLanguage,
                                        targetLanguage: 
suggestion.targetLanguage,
diff --git a/modules/dashboard/styles/ext.cx.lists.common.less 
b/modules/dashboard/styles/ext.cx.lists.common.less
index cc83072..4790d29 100644
--- a/modules/dashboard/styles/ext.cx.lists.common.less
+++ b/modules/dashboard/styles/ext.cx.lists.common.less
@@ -4,7 +4,7 @@
        padding: 12px;
        background-color: #fff;
        border-top: 1px solid #ddd;
-
+       cursor: pointer;
        &:hover {
                background-color: #eff3fb;
        }
diff --git a/modules/dashboard/styles/ext.cx.translationlist.less 
b/modules/dashboard/styles/ext.cx.translationlist.less
index 1ea142c..7523b23 100644
--- a/modules/dashboard/styles/ext.cx.translationlist.less
+++ b/modules/dashboard/styles/ext.cx.translationlist.less
@@ -3,8 +3,6 @@
 @import "mediawiki.mixins";
 
 .cx-tlitem {
-       cursor: pointer;
-
        &.cx-translation-deleted {
                opacity: 0.5;
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/238107
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I63bd26febe92b529e57b6987b6b6d2262b447dfb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits