jenkins-bot has submitted this change and it was merged.
Change subject: Use removeChild instead of remove
......................................................................
Use removeChild instead of remove
Node.prototype.remove is not available in some browsers (Krinkle: e.g. IE, Edge,
Mobile Safari, old Firefox), so use node.parentNode.removeChild( node ) instead.
Change-Id: I3c337d4f47fe9ee7624eda076c26d1699d6f9e70
---
M src/ce/ve.ce.Surface.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index f0a5567..7ce5697 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -3315,10 +3315,10 @@
return;
}
if ( this.cursorHolders.before ) {
- this.cursorHolders.before.remove();
+ this.cursorHolders.before.parentNode.removeChild(
this.cursorHolders.before );
}
if ( this.cursorHolders.after ) {
- this.cursorHolders.after.remove();
+ this.cursorHolders.after.parentNode.removeChild(
this.cursorHolders.after );
}
this.cursorHolders = null;
};
--
To view, visit https://gerrit.wikimedia.org/r/238328
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c337d4f47fe9ee7624eda076c26d1699d6f9e70
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Divec <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
