Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/238624

Change subject: Fix ResourceLoader module dependency issues
......................................................................

Fix ResourceLoader module dependency issues

If you visit desktop site and run
`mw.loader.using( 'mobile.settings' )` you'll notice before this
patch an exception is thrown. I suspect this is why debug=true
is failing in beta labs.

Bug: T112558
Change-Id: Iefb6723e24eef51cfbaf2e4a4c91ac3f1b0a93ba
---
M includes/Resources.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/24/238624/1

diff --git a/includes/Resources.php b/includes/Resources.php
index 7c43993..c982a52 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -410,6 +410,8 @@
        'mobile.settings' => $wgMFResourceFileModuleBoilerplate + array(
                'dependencies' => array(
                        'jquery.cookie',
+                       // Allow use of define
+                       'mobile.modules',
                        'mediawiki.storage',
                ),
                'scripts' => array(

-- 
To view, visit https://gerrit.wikimedia.org/r/238624
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iefb6723e24eef51cfbaf2e4a4c91ac3f1b0a93ba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to